Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-21 Thread Pali Rohár
On Wednesday 21 January 2015 12:01:31 Pavel Machek wrote: Strange, where do you see DOS style line breaks? Checkpatch here does not warn about that, and they really should not be there. If that would be the only pieces, then I would have fixed it already. That is not the big deal.

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-21 Thread Pavel Machek
Hi! Speaking about formatting, could you properly format your emails, that is inserting newline after ~78 columns, to make them easier to reply to? or you get an email client that can handle that part. My email client is configured ok. Your is not. You are speaking on public mailing

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Johan Hedberg
Hi Pavel, On Tue, Dec 23, 2014, Pavel Machek wrote: + while (1) { + int cmd, len; + + fw_pos += cmd_len; + + if (fw_pos = fw_entry-size) + break; + + if (fw_pos + 2 fw_entry-size) { +

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Marcel Holtmann
Hi Pavel, Add HCI driver for H4 with Nokia extensions. This device is used on Nokia N900 cell phone. Older version of this driver lived in staging, before being reverted in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Pavel Machek
Hi! Add HCI driver for H4 with Nokia extensions. This device is used on Nokia N900 cell phone. Older version of this driver lived in staging, before being reverted in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Pavel Machek
On Tue 2015-01-20 10:28:50, Johan Hedberg wrote: Hi Pavel, On Tue, Dec 23, 2014, Pavel Machek wrote: + while (1) { + int cmd, len; + + fw_pos += cmd_len; + + if (fw_pos = fw_entry-size) + break; + + if (fw_pos + 2

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-19 Thread Marcel Holtmann
Hi Pavel, Add HCI driver for H4 with Nokia extensions. This device is used on Nokia N900 cell phone. Older version of this driver lived in staging, before being reverted in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-18 Thread Pavel Machek
Hi! Add HCI driver for H4 with Nokia extensions. This device is used on Nokia N900 cell phone. Older version of this driver lived in staging, before being reverted in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . Any news here? I'd like the driver to hit 3.20...

Re: [PATCH] bluetooth: Add hci_h4p driver

2014-12-23 Thread Pavel Machek
Hi! + /* We should always send word aligned data to h4+ devices */ + if (skb-len % 2) { + err = skb_pad(skb, 1); + if (!err) + *skb_put(skb, 1) = 0x00; + } + if (err) + return err; This is crazy code. if (skb-len

Re: [PATCH] bluetooth: Add hci_h4p driver

2014-12-23 Thread Pavel Machek
Hi! Add hci_h4p bluetooth driver. This device is used for example on Nokia N900 cell phone. the driver is called nokia_h4p. And you could be a little bit more verbose here explaining where the driver came from. Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel

[PATCH] bluetooth: Add hci_h4p driver

2014-12-23 Thread Pavel Machek
Add HCI driver for H4 with Nokia extensions. This device is used on Nokia N900 cell phone. Older version of this driver lived in staging, before being reverted in a4102f90e87cfaa3fdbed6fdf469b23f0eeb4bfd . Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel s...@debian.org

[PATCH] bluetooth: Add hci_h4p driver

2014-12-20 Thread Pavel Machek
Add hci_h4p bluetooth driver. This device is used for example on Nokia N900 cell phone. Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel s...@debian.org Thanks-to: Joe Perches j...@perches.com --- Please apply,

Re: [PATCH] bluetooth: Add hci_h4p driver

2014-12-20 Thread Paul Bolle
Pavel, On Sat, 2014-12-20 at 21:23 +0100, Pavel Machek wrote: --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -243,4 +243,13 @@ config BT_WILINK Say Y here to compile support for Texas Instrument's WiLink7 driver into the kernel or say M to compile it as

Re: [PATCH] bluetooth: Add hci_h4p driver

2014-12-20 Thread Marcel Holtmann
Hi Pavel, Add hci_h4p bluetooth driver. This device is used for example on Nokia N900 cell phone. the driver is called nokia_h4p. And you could be a little bit more verbose here explaining where the driver came from. Signed-off-by: Pavel Machek pa...@ucw.cz Thanks-to: Sebastian Reichel