Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-31 Thread Jon Hunter
On 10/30/2012 10:10 AM, Felipe Balbi wrote: Hi, On Tue, Oct 30, 2012 at 09:16:34AM -0500, Jon Hunter wrote: Hi Felipe, On 10/30/2012 02:09 AM, Felipe Balbi wrote: ... its bit of an issue to take care. How do you ensure that GPIO does idle on SOC idle C-state attempts in such cases.

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 05:15:02AM -0500, Jon Hunter wrote: its bit of an issue to take care. How do you ensure that GPIO does idle on SOC idle C-state attempts in such cases. Today that job is done by omap_gpio_[prepare/resume]_for_idle. that's only there because we

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-31 Thread Kevin Hilman
Santosh Shilimkar santosh.shilim...@ti.com writes: [...] Just to summaries, there are 3 things we are talking here. Santosh, thanks for the summary. You are right on. 1. Delaying the idle with a timeout which $subject patch is trying to do to reduce latency for interrupts. That itself is

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-31 Thread Santosh Shilimkar
On Wednesday 31 October 2012 04:07 PM, Kevin Hilman wrote: Santosh Shilimkar santosh.shilim...@ti.com writes: [...] Just to summaries, there are 3 things we are talking here. Santosh, thanks for the summary. You are right on. 1. Delaying the idle with a timeout which $subject patch is

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-30 Thread Santosh Shilimkar
On Tuesday 30 October 2012 01:33 AM, Felipe Balbi wrote: Hi, On Mon, Oct 29, 2012 at 01:53:37PM +0530, Santosh Shilimkar wrote: Just to expand a bit, Out of 6 GPIO banks, GPIO1 bank is in always ON domain where as remaing 5 are in peripheral domain. Letting individual banks idle allowed you

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 12:02:17PM +0530, Santosh Shilimkar wrote: I still think mod_usage needs to go, so does omap_gpio_prepare_for_idle() and omap_gpio_resume_from_idle(). To me, it looks like that needs to be done on -prepare()/-complete() callbacks of system suspend and the gpio

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-30 Thread Jon Hunter
Hi Felipe, On 10/30/2012 02:09 AM, Felipe Balbi wrote: ... its bit of an issue to take care. How do you ensure that GPIO does idle on SOC idle C-state attempts in such cases. Today that job is done by omap_gpio_[prepare/resume]_for_idle. that's only there because we pm_runtime_get_sync()

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-30 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 09:16:34AM -0500, Jon Hunter wrote: Hi Felipe, On 10/30/2012 02:09 AM, Felipe Balbi wrote: ... its bit of an issue to take care. How do you ensure that GPIO does idle on SOC idle C-state attempts in such cases. Today that job is done by

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Santosh Shilimkar
+ Jon, On Friday 26 October 2012 06:49 PM, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on idle. If another access takes place before the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Felipe Balbi
On Mon, Oct 29, 2012 at 12:17:08PM +0530, Santosh Shilimkar wrote: + Jon, On Friday 26 October 2012 06:49 PM, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Santosh Shilimkar
On Monday 29 October 2012 01:35 PM, Felipe Balbi wrote: On Mon, Oct 29, 2012 at 12:17:08PM +0530, Santosh Shilimkar wrote: + Jon, On Friday 26 October 2012 06:49 PM, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Tim Niemeyer
Am Montag, den 29.10.2012, 12:17 +0530 schrieb Santosh Shilimkar: + Jon, On Friday 26 October 2012 06:49 PM, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Tim Niemeyer
Hello Am Freitag, den 26.10.2012, 23:01 +0300 schrieb Felipe Balbi: Hi, On Fri, Oct 26, 2012 at 03:19:13PM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-29 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 01:53:37PM +0530, Santosh Shilimkar wrote: Just to expand a bit, Out of 6 GPIO banks, GPIO1 bank is in always ON domain where as remaing 5 are in peripheral domain. Letting individual banks idle allowed you let the clock domain idle than keeping all the 6 banks and

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-27 Thread Santosh Shilimkar
On Saturday 27 October 2012 03:09 AM, Jon Hunter wrote: On 10/26/2012 03:01 PM, Felipe Balbi wrote: Hi, On Fri, Oct 26, 2012 at 03:19:13PM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in

[PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Tim Niemeyer
Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on idle. If another access takes place before the autosuspend timeout (2 secs), the call to resume the device can return

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Felipe Balbi
Hi, On Fri, Oct 26, 2012 at 09:55:30AM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on idle. If another access takes place before the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Tim Niemeyer
Am Freitag, den 26.10.2012, 11:03 +0300 schrieb Felipe Balbi: Hi, On Fri, Oct 26, 2012 at 09:55:30AM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Felipe Balbi
On Fri, Oct 26, 2012 at 12:42:35PM +0200, Tim Niemeyer wrote: Am Freitag, den 26.10.2012, 11:03 +0300 schrieb Felipe Balbi: Hi, On Fri, Oct 26, 2012 at 09:55:30AM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power

[PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Tim Niemeyer
Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on idle. If another access takes place before the autosuspend timeout (2 secs), the call to resume the device can return

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Felipe Balbi
Hi, On Fri, Oct 26, 2012 at 03:19:13PM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on idle. If another access takes place before the

Re: [PATCH] gpio: omap-gpio: add support for pm_runtime autosuspend

2012-10-26 Thread Jon Hunter
On 10/26/2012 03:01 PM, Felipe Balbi wrote: Hi, On Fri, Oct 26, 2012 at 03:19:13PM +0200, Tim Niemeyer wrote: Adds support for configuring the omap-gpio driver use autosuspend for runtime power management. This can reduce the latency in using it by not suspending the device immediately on