Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-21 Thread Peter Ujfalusi
On 12/19/2015 03:30 PM, Aaro Koskinen wrote: > Probably DMA support is not that critical. Looks like with DT boot it's > not even possible to enable it at the moment. I think by adding 'dma-channel' property is there to enable the DMA mode via DT. As for stripping out the DMA support: I'm fine

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-19 Thread Aaro Koskinen
Hi, On Fri, Dec 18, 2015 at 10:39:48AM -0800, Tony Lindgren wrote: > * Brian Norris [151218 10:11]: > > On Mon, Dec 14, 2015 at 11:49:32AM +0200, Peter Ujfalusi wrote: > > > We have 4 functions containing almost identical DMA setup code. Create one > > > function

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-18 Thread Brian Norris
On Mon, Dec 14, 2015 at 11:49:32AM +0200, Peter Ujfalusi wrote: > We have 4 functions containing almost identical DMA setup code. Create one > function which can set up the DMA for both read and write and use this in > place for the setup code in the driver. > The new function will use

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-18 Thread Tony Lindgren
* Brian Norris [151218 10:11]: > On Mon, Dec 14, 2015 at 11:49:32AM +0200, Peter Ujfalusi wrote: > > We have 4 functions containing almost identical DMA setup code. Create one > > function which can set up the DMA for both read and write and use this in > > place for

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-18 Thread Peter Ujfalusi
On 12/18/2015 08:11 PM, Brian Norris wrote: > On Mon, Dec 14, 2015 at 11:49:32AM +0200, Peter Ujfalusi wrote: >> We have 4 functions containing almost identical DMA setup code. Create one >> function which can set up the DMA for both read and write and use this in >> place for the setup code in

Re: [PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-18 Thread Brian Norris
On Fri, Dec 18, 2015 at 09:48:09PM +0200, Peter Ujfalusi wrote: > On 12/18/2015 08:11 PM, Brian Norris wrote: > > Peter, are you actually using this, or are you just refactoring for the > > fun of it? > > Not really for fun, but I want to get rid of all legacy/direct sDMA use so at > the end we

[PATCH] mtd: onenand: omap2: Simplify the DMA setup for various paths

2015-12-14 Thread Peter Ujfalusi
We have 4 functions containing almost identical DMA setup code. Create one function which can set up the DMA for both read and write and use this in place for the setup code in the driver. The new function will use wait_for_completion_timeout() and it will figure out the best data_type to be used