Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-20 Thread Wim Van Sebroeck
Hi Timo, It seems that in this patch, you disable the watchdog regardless whether the registration fails or not. I wonder if this is a good thing to do. What if the bootloader have already enabled the watchdog and then user space booting fails for some reason before any process is able to

Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-20 Thread Timo Kokkonen
Hi Wim, On Thu, 2010-05-20 at 09:46 +0200, ext Wim Van Sebroeck wrote: = bottom line: this patch adds the correct default behaviour and should not be changed. Feel free to add the module-parameter to keep the watchog running at start. Thanks for the detailed explanation. I was worried about

Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-19 Thread Wim Van Sebroeck
Hi Ameya, If we are not able to register then it is better to have watchdog in disabled state than noticing a system reboot. Signed-off-by: Ameya Palande ameya.pala...@nokia.com This was added in my linux-2.6-watchdog-next tree. Will be sent to Linus for mainline inclusion in a couple of

Re: [PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-19 Thread Timo Kokkonen
Hi, On Mon, 2010-05-17 at 13:12 +0200, Palande Ameya (Nokia-D/Helsinki) wrote: If we are not able to register then it is better to have watchdog in disabled state than noticing a system reboot. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/watchdog/twl4030_wdt.c |2

[PATCH] twl4030_wdt: Disable watchdog while probing

2010-05-17 Thread Ameya Palande
If we are not able to register then it is better to have watchdog in disabled state than noticing a system reboot. Signed-off-by: Ameya Palande ameya.pala...@nokia.com --- drivers/watchdog/twl4030_wdt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git