Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Felipe Balbi
On Tue, Feb 03, 2015 at 06:21:24PM -0200, Fabio Estevam wrote: Hi Felipe, On Sun, Feb 1, 2015 at 3:37 PM, Felipe Balbi ba...@ti.com wrote: I like this, very much. Two comments though. We requested the gpio with _optional(), and NULL is a valid gpio_desc, this if (nop-gpiod_reset) is

Re: [PATCH] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

2015-02-03 Thread Fabio Estevam
On Tue, Feb 3, 2015 at 6:52 PM, Felipe Balbi ba...@ti.com wrote: it doesn't make a difference though, right ? gpiod_direction_output(NULL, 1) won't do anything. Yes, I will send a v3 without the NULL check. gpiod_set_value returns immediately if desc is NULL: void gpiod_set_value(struct