Re: [PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

2012-05-10 Thread Roger Quadros
Hi, \ On 05/03/2012 10:26 AM, R Sricharan wrote: Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision detection support. Signed-off-by: R Sricharan r.sricha...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/control.h |4 +++

Re: [PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

2012-05-10 Thread R, Sricharan
Hi Roger, +void __init omap5xxx_check_revision(void) +{ +     u32 idcode; +     u16 hawkeye; +     u8 rev; + +     idcode = read_tap_reg(OMAP_TAP_IDCODE); +     hawkeye = (idcode 12) 0x; +     rev = (idcode 28) 0xff; +     switch (hawkeye) { +     case 0xb942: +            

Re: [PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

2012-05-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On 12:56 Thu 03 May , R Sricharan wrote: Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision detection support. Signed-off-by: R Sricharan r.sricha...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/control.h |4 +++

Re: [PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

2012-05-10 Thread R, Sricharan
Hi J, why do you duplicate this +                     break; +             case 1: +                     omap_revision = OMAP5430_REV_ES2_0; +                     break; do this                case 0: +             default: +                     omap_revision = OMAP5430_REV_ES1_0; +    

[PATCH 01/13] ARM: OMAP5: id: Add cpu id for ES versions

2012-05-03 Thread R Sricharan
Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision detection support. Signed-off-by: R Sricharan r.sricha...@ti.com Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/control.h |4 +++ arch/arm/mach-omap2/id.c | 47