Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-24 Thread Thomas Petazzoni
Hello Mark, On Fri, 3 Sep 2010 19:20:52 +0100 Mark Brown broo...@opensource.wolfsonmicro.com wrote: Essentially all that needs doing is that when regulator_set_voltage() is called instead of merging with the machine constraints and applying the setting immediately we store the constraints

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-24 Thread Mark Brown
On Wed, Nov 24, 2010 at 10:45:44AM +0100, Thomas Petazzoni wrote: I went ahead and implemented this (without looking at previous existing code since I couldn't find it). What about the following patch ? That's pretty much exactly what the old code did - told you it was trivial :) -- To

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-11-23 Thread Thomas Petazzoni
Hello Mark, On Fri, 3 Sep 2010 19:20:52 +0100 Mark Brown broo...@opensource.wolfsonmicro.com wrote: re-add? was it there at one point and removed? Any pointers to the old code? It was present in the pre-merge regulator API which you can find in the bowels of:

RE: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-17 Thread Gopinath, Thara
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 16, 2010 8:50 PM To: Gopinath, Thara Cc: linux-omap@vger.kernel.org; p...@pwsan.com; Sripathy, Vishwanath; Sawant, Anand; Cousson, Benoit Subject: Re: [PATCH 01/13] OMAP: Introduce a

RE: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-16 Thread Gopinath, Thara
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Saturday, August 28, 2010 5:23 AM To: Gopinath, Thara Cc: linux-omap@vger.kernel.org; p...@pwsan.com; Sripathy, Vishwanath; Sawant, Anand; Cousson, Benoit Subject: Re: [PATCH 01/13] OMAP: Introduce a user

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-16 Thread Kevin Hilman
Gopinath, Thara th...@ti.com writes: [...] + * omap_voltage_add_userreq : API to keep track of various requests to + *scale the VDD and returns the best possible + *voltage the VDD can be put to. + * @volt_domain: pointer to the voltage

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-06 Thread Mark Brown
On Fri, Sep 03, 2010 at 11:27:50AM -0700, Kevin Hilman wrote: In the background Thomas and I will continue to research the changes needed in the regulator framework. These really are fairly straightforward, the algorithm I outlined in my last mail will do the trick. -- To unsubscribe from this

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-06 Thread Eduardo Valentin
Hello, On Fri, Sep 03, 2010 at 08:20:52PM +0200, Mark Brown wrote: On Fri, Sep 03, 2010 at 11:00:31AM -0700, Kevin Hilman wrote: Mark Brown broo...@opensource.wolfsonmicro.com writes: The only thing I can think you might need to do if this is just straight voltage setting is re-add

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-06 Thread Liam Girdwood
On Mon, 2010-09-06 at 22:59 +0300, Eduardo Valentin wrote: Hello, On Fri, Sep 03, 2010 at 08:20:52PM +0200, Mark Brown wrote: On Fri, Sep 03, 2010 at 11:00:31AM -0700, Kevin Hilman wrote: Mark Brown broo...@opensource.wolfsonmicro.com writes: The only thing I can think you might

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-06 Thread Mark Brown
On Mon, Sep 06, 2010 at 10:59:05PM +0300, Eduardo Valentin wrote: On Fri, Sep 03, 2010 at 08:20:52PM +0200, Mark Brown wrote: Essentially all that needs doing is that when regulator_set_voltage() is called instead of merging with the machine constraints and applying the setting immediately

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-03 Thread Kevin Hilman
+ Mark, Liam for regulator questions, thread in archives here: http://marc.info/?l=linux-omapm=128349777617270w=2 Gopinath, Thara th...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 02, 2010 4:22 AM To: Gopinath,

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-03 Thread Mark Brown
On Fri, Sep 03, 2010 at 09:41:11AM -0700, Kevin Hilman wrote: Like you, I'm no expert on the regulator framework internals, but it appears to have a pretty thorough system of constraints management that upon first glance seems to be a good fit for what we need. It may need to be extended,

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-03 Thread Kevin Hilman
Mark Brown broo...@opensource.wolfsonmicro.com writes: On Fri, Sep 03, 2010 at 09:41:11AM -0700, Kevin Hilman wrote: Like you, I'm no expert on the regulator framework internals, but it appears to have a pretty thorough system of constraints management that upon first glance seems to be a

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-03 Thread Mark Brown
On Fri, Sep 03, 2010 at 11:00:31AM -0700, Kevin Hilman wrote: Mark Brown broo...@opensource.wolfsonmicro.com writes: The only thing I can think you might need to do if this is just straight voltage setting is re-add support for multiple consumers setting voltages simultaneously Yeah,

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-03 Thread Kevin Hilman
Gopinath, Thara th...@ti.com writes: [...] I agree probably regulator framework would be the best place for this but then IMO regulator framework needs a lot of changes to support the kind of use-counting we need in the voltage layer. To start with regulator_get keeps the use counting only

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Thomas Petazzoni
Hello, On Wed, 01 Sep 2010 15:51:40 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: Looking closer at this, keeping track of a list of devices and constraints is what the regulator framework does as well. Before we get too far down this path, we need to start working with Thomas

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Nishanth Menon
Thomas Petazzoni had written, on 09/02/2010 02:43 AM, the following: Hello, On Wed, 01 Sep 2010 15:51:40 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: Looking closer at this, keeping track of a list of devices and constraints is what the regulator framework does as well. Before we

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Felipe Balbi
On Thu, 2 Sep 2010 03:17:56 -0500, Nishanth Menon n...@ti.com wrote: Just brainstorming - if we use the regulator framework - there are potential benefits - agreed. BUT, consider the cpuidle path - currently we disable SR while hitting off/ret for class3, this is done in irq locked context

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Nishanth Menon
Felipe Balbi had written, on 09/02/2010 05:00 AM, the following: On Thu, 2 Sep 2010 03:17:56 -0500, Nishanth Menon n...@ti.com wrote: Just brainstorming - if we use the regulator framework - there are potential benefits - agreed. BUT, consider the cpuidle path - currently we disable SR while

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Felipe Balbi
Hi, On Thu, 2 Sep 2010 05:17:01 -0500, Nishanth Menon n...@ti.com wrote: note - if we allow unlock of irqs at this point, we cannot predictably progress down the logic. spin_unlock() would not re-enable IRQs, would it ? Isn't it so that spin_unlock_irq() would be the one re-enabling IRQ ? --

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Nishanth Menon
Felipe Balbi had written, on 09/02/2010 05:28 AM, the following: Hi, On Thu, 2 Sep 2010 05:17:01 -0500, Nishanth Menon n...@ti.com wrote: note - if we allow unlock of irqs at this point, we cannot predictably progress down the logic. spin_unlock() would not re-enable IRQs, would it ? Isn't

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Felipe Balbi
Hi, On Thu, 2 Sep 2010 05:40:56 -0500, Nishanth Menon n...@ti.com wrote: Felipe Balbi had written, on 09/02/2010 05:28 AM, the following: Hi, On Thu, 2 Sep 2010 05:17:01 -0500, Nishanth Menon n...@ti.com wrote: note - if we allow unlock of irqs at this point, we cannot predictably

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Thomas Petazzoni had written, on 09/02/2010 02:43 AM, the following: Hello, On Wed, 01 Sep 2010 15:51:40 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: Looking closer at this, keeping track of a list of devices and constraints is what the

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Nishanth Menon
Kevin Hilman had written, on 09/02/2010 12:47 PM, the following: Nishanth Menon n...@ti.com writes: Thomas Petazzoni had written, on 09/02/2010 02:43 AM, the following: Hello, On Wed, 01 Sep 2010 15:51:40 -0700 Kevin Hilman khil...@deeprootsystems.com wrote: Looking closer at this, keeping

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-02 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 09/02/2010 12:47 PM, the following: [...] If you look at the current PM branch (specifically pm-sr), you'll see that with the updated SR layer, there is no SR enable/disable in the idle path because there is no voltage scaling

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-09-01 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes: This patch introduces a user list of devices associated with each voltage domain instance. The user list is implemented using plist structure with priority node populated with the voltage values. This patch also adds an API which will take in a device and

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-08-30 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: +if (!found) { +user = kzalloc(sizeof(struct omap_vdd_user_list), GFP_KERNEL); +if (!user) { +pr_err(%s: Unable to creat a new user for vdd_%s\n, +__func__,

Re: [PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-08-27 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes: This patch introduces a user list of devices associated with each voltage domain instance. The user list is implemented using plist structure with priority node populated with the voltage values. This patch also adds an API which will take in a device and

[PATCH 01/13] OMAP: Introduce a user list for each voltage domain instance in the voltage driver.

2010-08-18 Thread Thara Gopinath
This patch introduces a user list of devices associated with each voltage domain instance. The user list is implemented using plist structure with priority node populated with the voltage values. This patch also adds an API which will take in a device and requested voltage as parameters, adds the