Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Shawn Guo
On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: ... diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c index 5cca573..7e00748 100644 --- a/arch/arm/mach-imx/imx51-dt.c +++ b/arch/arm/mach-imx/imx51-dt.c @@ -102,7 +102,7 @@ static struct sys_timer

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 23:12 Thu 29 Mar , Uwe Kleine-König wrote: As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: ... diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c index 5cca573..7e00748 100644 --- a/arch/arm/mach-imx/imx51-dt.c +++

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Shawn Guo
On Fri, Mar 30, 2012 at 11:50:24AM +0200, Uwe Kleine-König wrote: Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: ... diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Tony Lindgren
* Uwe Kleine-König u.kleine-koe...@pengutronix.de [120329 14:16]: As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict

[PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-29 Thread Uwe Kleine-König
As long as there is no other non-const variable marked __initdata in the same compilation unit it doesn't hurt. If there were one however compilation would fail with error: $variablename causes a section type conflict because a section containing const variables is marked read only and

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-29 Thread David Brown
On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: arch/arm/mach-msm/board-msm8x60.c |2 +- arch/arm/mach-msm/board-qsd8x50.c |4 +- Acked-by: David Brown dav...@codeaurora.org -- Sent by an employee of the Qualcomm Innovation Center, Inc. The