Re: [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5.

2012-05-08 Thread R, Sricharan
Tony, On Mon, May 7, 2012 at 11:04 PM, Tony Lindgren t...@atomide.com wrote: * R, Sricharan r.sricha...@ti.com [120506 00:42]: Hi Tony, -     if (!(cpu_is_omap44xx())) +     if ((!(cpu_is_omap44xx())) (!cpu_is_omap54xx()))               return -ENODEV;       for (i = 0; i

Re: [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5.

2012-05-07 Thread Tony Lindgren
* R, Sricharan r.sricha...@ti.com [120506 00:42]: Hi Tony, -     if (!(cpu_is_omap44xx())) +     if ((!(cpu_is_omap44xx())) (!cpu_is_omap54xx()))               return -ENODEV;       for (i = 0; i L3_MODULES; i++) { Isn't there some unnecessary parens here? You mean in this

Re: [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5.

2012-05-06 Thread R, Sricharan
Hi Tony, -     if (!(cpu_is_omap44xx())) +     if ((!(cpu_is_omap44xx())) (!cpu_is_omap54xx()))               return -ENODEV;       for (i = 0; i L3_MODULES; i++) { Isn't there some unnecessary parens here? You mean in this above for loop?. There are multiple statements . Thanks,

Re: [PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5.

2012-05-04 Thread Tony Lindgren
* R Sricharan r.sricha...@ti.com [120503 00:30]: --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -85,7 +85,7 @@ static int __init omap4_l3_init(void) * To avoid code running on other OMAPs in * multi-omap builds */ - if

[PATCH 07/13] ARM: OMAP5: l3: Add l3 error handler support for omap5.

2012-05-03 Thread R Sricharan
The l3 interconnect ip is same for OMAP4 and OMAP5. So reuse the l3 error handler error code for OMAP5 as well. Also a few targets has been newly added for OMAP5. So updating the driver for that here. Signed-off-by: R Sricharan r.sricha...@ti.com --- arch/arm/mach-omap2/Makefile |1 +