Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-21 Thread Linus Walleij
On Fri, Jan 16, 2015 at 11:50 PM, Tony Lindgren t...@atomide.com wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access after setup_irq(): WARNING: CPU:

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-21 Thread Javier Martinez Canillas
Hello Tony, On Fri, Jan 16, 2015 at 11:50 PM, Tony Lindgren t...@atomide.com wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access after setup_irq():

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-19 Thread santosh.shilim...@oracle.com
On 1/16/15 5:00 PM, Tony Lindgren wrote: * santosh shilimkar santosh.shilim...@oracle.com [150116 16:23]: On 1/16/2015 2:50 PM, Tony Lindgren wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request().

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-17 Thread Russell King - ARM Linux
On Fri, Jan 16, 2015 at 04:19:41PM -0800, santosh shilimkar wrote: On 1/16/2015 2:50 PM, Tony Lindgren wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device

[PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-16 Thread Tony Lindgren
Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access after setup_irq(): WARNING: CPU: 0 PID: 1 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x214/0x340()

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-16 Thread Felipe Balbi
On Fri, Jan 16, 2015 at 02:50:50PM -0800, Tony Lindgren wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access after setup_irq(): WARNING: CPU: 0 PID: 1

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-16 Thread santosh shilimkar
On 1/16/2015 2:50 PM, Tony Lindgren wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access after setup_irq(): I let Linus W comment on it but IIRC we chewed

Re: [PATCH 1/1] gpio: omap: Fix bad device access with setup_irq()

2015-01-16 Thread Tony Lindgren
* santosh shilimkar santosh.shilim...@oracle.com [150116 16:23]: On 1/16/2015 2:50 PM, Tony Lindgren wrote: Similar to omap_gpio_irq_type() let's make sure that the GPIO is usable as an interrupt if the platform init code did not call gpio_request(). Otherwise we can get invalid device access