Re: [PATCH 1/1] mfd: twl4030: clarify the return value for read and write

Hi Amit, On Mon, Dec 07, 2009 at 03:53:09PM +0200, Eduardo Valentin wrote: On Mon, Dec 07, 2009 at 01:17:29PM +0100, ext Amit Kucheria wrote: Infact, we can just return -EIO so that caller knows for sure that all messages were not tranferred. Please consider fixed patch instead. We

Re: [PATCH 1/1] mfd: twl4030: clarify the return value for read and write

On Fri, Dec 11, 2009 at 11:36:10AM +0100, ext Samuel Ortiz wrote: Hi Amit, On Mon, Dec 07, 2009 at 03:53:09PM +0200, Eduardo Valentin wrote: On Mon, Dec 07, 2009 at 01:17:29PM +0100, ext Amit Kucheria wrote: Infact, we can just return -EIO so that caller knows for sure that all

[PATCH 1/1] mfd: twl4030: clarify the return value for read and write

Infact, we can just return -EIO so that caller knows for sure that all messages were not tranferred. Please consider fixed patch instead. We should be checking if all the messages were tranferred or not. And return -1 for failure. Currently we return success (0) even if none of messages were

Re: [PATCH 1/1] mfd: twl4030: clarify the return value for read and write

On Mon, Dec 07, 2009 at 01:17:29PM +0100, ext Amit Kucheria wrote: Infact, we can just return -EIO so that caller knows for sure that all messages were not tranferred. Please consider fixed patch instead. We should be checking if all the messages were tranferred or not. And return -1 for