Re: [PATCH 1/2] ARM: OMAP: dmtimer: fix sleeping function called from invalid context

2011-12-12 Thread Tony Lindgren
* Ramirez Luna, Omar omar.rami...@ti.com [111209 13:38]: On Fri, Dec 9, 2011 at 3:34 PM, Tony Lindgren t...@atomide.com wrote: +     ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ); ...  EXPORT_SYMBOL_GPL(omap_dm_timer_request); This does not seem right.. It seems that

Re: [PATCH 1/2] ARM: OMAP: dmtimer: fix sleeping function called from invalid context

2011-12-12 Thread Ramirez Luna, Omar
On Mon, Dec 12, 2011 at 5:08 PM, Tony Lindgren t...@atomide.com wrote: ... @@ -134,22 +134,13 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer)  int omap_dm_timer_prepare(struct omap_dm_timer *timer)  { ... -       ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);

Re: [PATCH 1/2] ARM: OMAP: dmtimer: fix sleeping function called from invalid context

2011-12-09 Thread Tony Lindgren
* Omar Ramirez Luna omar.rami...@ti.com [24 19:37]: omap_dm_timer_request* holds a spin_lock_irqsave while inner routines call clk_get_sys which holds a mutex_lock, given that mutex can be put to sleep a BUG message is triggered. This occurs in 2 ocassions. 1. When the fck is gotten at

Re: [PATCH 1/2] ARM: OMAP: dmtimer: fix sleeping function called from invalid context

2011-12-09 Thread Ramirez Luna, Omar
On Fri, Dec 9, 2011 at 3:34 PM, Tony Lindgren t...@atomide.com wrote: +     ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ); ...  EXPORT_SYMBOL_GPL(omap_dm_timer_request); This does not seem right.. It seems that you're hardcoding the source clock to 32 KiHz clock while other

[PATCH 1/2] ARM: OMAP: dmtimer: fix sleeping function called from invalid context

2011-11-24 Thread Omar Ramirez Luna
omap_dm_timer_request* holds a spin_lock_irqsave while inner routines call clk_get_sys which holds a mutex_lock, given that mutex can be put to sleep a BUG message is triggered. This occurs in 2 ocassions. 1. When the fck is gotten at the beginning of omap_dm_timer_prepare by using clk_get