Re: [PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-20 Thread David Brownell
On Tuesday 13 January 2009, David Brownell wrote:  static int tps6235x_dcdc_set_voltage(struct regulator_dev *dev, int min_uV, int max_uV)  { +   struct tps *tps = rdev_get_drvdata(dev); +   const struct tps_info *info = tps-info; unsigned char

Re: [PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-20 Thread Mark Brown
On Tue, Jan 20, 2009 at 11:06:00AM -0800, David Brownell wrote: On Tuesday 13 January 2009, David Brownell wrote: +   /* adjust to match supported range, fail if out of range */ +   if (min_uV info-min_uV) +   min_uV = info-min_uV; +   if (max_uV info-max_uV)

Re: [PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-14 Thread David Brownell
On Wednesday 14 January 2009, Pillai, Manikandan wrote: Let me summarise the main problem I have been facing with regulators. The TPS6235x are I2C based devices. The regulator_register() functions require that the regulator_init_data is passed as platform_data(). But for i2c_client's

Re: [PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-14 Thread Mark Brown
On Wed, Jan 14, 2009 at 09:55:58AM -0800, David Brownell wrote: problem vanishes. Only the tps6235x.c driver, and in this case the regulator framework (sigh), care about that platform_data. The regulator framework will be fixed in .30. -- To unsubscribe from this list: send the line

Re: [PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-14 Thread David Brownell
On Wednesday 14 January 2009, Mark Brown wrote: On Wed, Jan 14, 2009 at 09:55:58AM -0800, David Brownell wrote: problem vanishes. Only the tps6235x.c driver, and in this case the regulator framework (sigh), care about that platform_data. The regulator framework will be fixed in .30.

[PATCH 1/2] Include TPS6235x based Power regulator support

2009-01-12 Thread Manikandan Pillai
This patch provides the changes required for TPS6235x power regulator support. The driver is put in drivers/regulator/tps6235x-regulator.c. The Kconfig and Makefile are modified for build. This patch should be used alongwith Patch[2/2]. The framework for the build is included. The build will