Re: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com Would a more static approach be cleaner? I mean something like this (pseudo code): static struct omap_dss_features

Re: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com And some more comments inline --- drivers/video/omap2/dss/dss_features.c | 197

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com And some more comments inline --- drivers/video/omap2/dss/dss_features.c | 197

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
On Tue, 2010-09-07 at 13:05 +0200, ext Taneja, Archit wrote: Hi, There are 2 functions in the present code: omap_dss_get_num_overlays() omap_dss_get_num_overlay_managers() They look very similar to the dss_feature functions but are required. I will need to come up with new names for them

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com Would a more static approach be cleaner? I mean something like this (pseudo code):

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Tomi Valkeinen
On Tue, 2010-09-07 at 13:31 +0200, ext Taneja, Archit wrote: Hi, Tomi Valkeinen wrote: Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com Would a more

RE: [PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-09-07 Thread Taneja, Archit
Hi, Tomi Valkeinen wrote: On Tue, 2010-09-07 at 13:31 +0200, ext Taneja, Archit wrote: Hi, Tomi Valkeinen wrote: Hi, On Thu, 2010-08-26 at 14:43 +0200, ext Archit Taneja wrote: Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja

[PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-08-26 Thread y
From: Archit Taneja arc...@ti.com Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c | 197 drivers/video/omap2/dss/dss_features.h | 48 2 files

[PATCH 1/2] OMAP: DSS2: Introduce dss_features files

2010-08-26 Thread Archit Taneja
Add dss_features.c and dss_features.h for the dss_features framework Signed-off-by: Archit Taneja arc...@ti.com --- drivers/video/omap2/dss/dss_features.c | 197 drivers/video/omap2/dss/dss_features.h | 48 2 files changed, 245 insertions(+), 0