Re: [PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-26 Thread arun c
On Wed, Jun 25, 2008 at 8:43 PM, Miguel Angel Aguilar Ulloa [EMAIL PROTECTED] wrote: The OMAP3 EVM has 15 keys arranged in a matrix from SW4 to SW18, but it also has a user key (power on/off) in SW3, this key is included in the keypad mapping. This is how mapping is done in an 4x4 array. arun

Re: [PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-25 Thread arun c
On Tue, Jun 24, 2008 at 3:21 AM, Miguel Angel Aguilar Ulloa [EMAIL PROTECTED] wrote: Add twl4030 keypad driver support to OMAP3 EVM Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/arch/arm/mach-omap2/board-omap3evm.c 2008-06-23 15:07:13.0 -0600 +++

Re: [PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-25 Thread Miguel Angel Aguilar Ulloa
The OMAP3 EVM has 15 keys arranged in a matrix from SW4 to SW18, but it also has a user key (power on/off) in SW3, this key is included in the keypad mapping. This is how mapping is done in an 4x4 array. arun c wrote: On Tue, Jun 24, 2008 at 3:21 AM, Miguel Angel Aguilar Ulloa [EMAIL

[PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Miguel Angel Aguilar Ulloa
Add twl4030 keypad driver support to OMAP3 EVM Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/arch/arm/mach-omap2/board-omap3evm.c 2008-06-23 15:07:13.0 -0600 +++ b/arch/arm/mach-omap2/board-omap3evm.c 2008-06-23 14:32:29.0 -0600 @@ -19,6 +19,7 @@

Re: [PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Felipe Balbi
On Mon, Jun 23, 2008 at 03:51:09PM -0600, Miguel Angel Aguilar Ulloa wrote: Add twl4030 keypad driver support to OMAP3 EVM Generally all your patches look really good but the subject should be something more self-explanatory. For this first is ok, but second and third should be something like: