RE: [PATCH 1/4] PM: Dynamic GPIO clock handling

2008-09-12 Thread Tero.Kristo
These comments should now be fixed in the new version I just sent out. -Tero -Original Message- From: Högander Jouni [mailto:[EMAIL PROTECTED] Sent: 05 September, 2008 16:47 To: ext Paul Walmsley Cc: Kristo Tero (Nokia-D/Tampere); linux-omap@vger.kernel.org Subject: Re: [PATCH 1/4] PM

Re: [PATCH 1/4] PM: Dynamic GPIO clock handling

2008-09-05 Thread Paul Walmsley
Hello Tero, Jouni, so is this basically a workaround patch? a few comments: On Wed, 27 Aug 2008, Tero Kristo wrote: From: ext Jouni Hogander [EMAIL PROTECTED] In omap3 gpios 2-6 are in per domain. Functional clocks for these should be disabled. GPIO modules in PER domain are not able

Re: [PATCH 1/4] PM: Dynamic GPIO clock handling

2008-09-05 Thread Högander Jouni
ext Paul Walmsley [EMAIL PROTECTED] writes: Hello Tero, Jouni, so is this basically a workaround patch? Yes in new format. Please do not use word workaround;) a few comments: On Wed, 27 Aug 2008, Tero Kristo wrote: From: ext Jouni Hogander [EMAIL PROTECTED] In omap3 gpios 2-6 are in

[PATCH 1/4] PM: Dynamic GPIO clock handling

2008-08-27 Thread Tero Kristo
From: ext Jouni Hogander [EMAIL PROTECTED] In omap3 gpios 2-6 are in per domain. Functional clocks for these should be disabled. GPIO modules in PER domain are not able to act as a wake up source if PER domain is in retention. PER domain sleep transition before MPU is prevented by leaving icks