Mark,
On Tue, Dec 28, 2010 at 8:18 AM, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote:
+ case 1920:
+ if (div == 5)
+ div_sel = 0x1;
+ else if (div == 8)
+
On Wed, Jan 05, 2011 at 07:56:13AM -0600, Lambert, David wrote:
On Tue, Dec 28, 2010 at 8:18 AM, Mark Brown
A comment explaining why we don't actually do anything with the request
would be helpful. Given that we're ignoring the event it'd seem better
to just leave it masked and not take
Hi,
On Tue, Dec 28, 2010 at 07:13:58PM -0600, Lambert, David wrote:
one blank line only. BTW, are these used anywwhere outside the dmic.c
driver ? If not, it's better to move the definitions there.
They were originally in the omap-dmic.h header, but it was suggested
that we move
them to a
On Wed, 2010-12-29 at 11:47 +0200, Felipe Balbi wrote:
Hi,
On Tue, Dec 28, 2010 at 07:13:58PM -0600, Lambert, David wrote:
one blank line only. BTW, are these used anywwhere outside the dmic.c
driver ? If not, it's better to move the definitions there.
They were originally in the
Hi,
On Wed, Dec 29, 2010 at 10:35:31AM +, Liam Girdwood wrote:
Even though the driver will never work with those other archs, compile
testing with several of them isn't bad at all.
This seems unnecessary since this driver is for the OMAP platform only
and also means maintainers will have
On Wed, 2010-12-29 at 12:44 +0200, Felipe Balbi wrote:
Hi,
On Wed, Dec 29, 2010 at 10:35:31AM +, Liam Girdwood wrote:
Even though the driver will never work with those other archs, compile
testing with several of them isn't bad at all.
This seems unnecessary since this driver is for
On Wed, Dec 29, 2010 at 11:52:51AM +, Liam Girdwood wrote:
In this case though the other McBSP user afaik is DaVinci, so in this
case it does make sense to make this driver support both.
The other thing with McBSP is that it's a generic programmable serial
port and so need not be tied to
Hi,
On Wed, Dec 29, 2010 at 11:56:28AM +, Mark Brown wrote:
In this case though the other McBSP user afaik is DaVinci, so in this
case it does make sense to make this driver support both.
The other thing with McBSP is that it's a generic programmable serial
port and so need not be tied to
Hi,
On Wed, Dec 29, 2010 at 11:52:51AM +, Liam Girdwood wrote:
I agree that drivers should be arch independent when possible, but in
this case the OMAP DMIC DAI driver is coupled to the OMAP platform only.
i.e. it performs IO directly on the OMAP DMIC IP. This IP is only found
on OMAP
On Wed, Dec 29, 2010 at 01:59:24PM +0200, Felipe Balbi wrote:
On Wed, Dec 29, 2010 at 11:56:28AM +, Mark Brown wrote:
The other thing with McBSP is that it's a generic programmable serial
port and so need not be tied to audio use (though as I understand it
other uses are very rare).
So
On Wed, 2010-12-29 at 14:04 +0200, Felipe Balbi wrote:
Hi,
On Wed, Dec 29, 2010 at 11:52:51AM +, Liam Girdwood wrote:
I agree that drivers should be arch independent when possible, but in
this case the OMAP DMIC DAI driver is coupled to the OMAP platform only.
i.e. it performs IO
Hi,
On Wed, Dec 29, 2010 at 01:00:00PM +, Liam Girdwood wrote:
Ok, I now think you meant other ARM architectures here than other
Linux architectures in general. It does make a more sense for ARM
distribution deployment, but I still think guaranteeing successful build
for this driver on all
Hi,
On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote:
This patch adds support for the OMAP4 digital microphone DAI.
This DAI can support support recording in 2, 4, or 6 channels
When provided with a 19.2Mhz functional clock, can encode at 96Khz or
192Khz (all
channels must have
On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote:
+ case 1920:
+ if (div == 5)
+ div_sel = 0x1;
+ else if (div == 8)
+ div_sel = 0x0;
+ break;
A switch statement for the valid div values would
On Tue, Dec 28, 2010 at 5:14 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Dec 27, 2010 at 10:17:02PM -0600, David Lambert wrote:
This patch adds support for the OMAP4 digital microphone DAI.
This DAI can support support recording in 2, 4, or 6 channels
When provided with a 19.2Mhz
15 matches
Mail list logo
