Hi Balbi,
And thanks for the review. I'll fix your comments and resend the series
;-)
Thanks because I had the same objections then Russell.
Greetings,
Wim.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo
These are changes that have been sitting in linux-omap
and were never sent upstream.
Hopefully, it'll never happen again at least for this
driver.
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
---
arch/arm/plat-omap/devices.c | 21 ++--
drivers/watchdog/omap_wdt.c | 287
You're getting there with this patch, but still not completely up to
snuff.
On Fri, Sep 19, 2008 at 01:32:35PM +0300, Felipe Balbi wrote:
diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
index 3a11dad..e55f2cc 100644
--- a/drivers/watchdog/omap_wdt.c
+++
On Friday 19 September 2008, Felipe Balbi wrote:
- * linux/drivers/char/watchdog/omap_wdt.c
+ * linux/drivers/watchdog/omap_wdt.c
current style omits the paths (just use omap_wdt.c)
since they change periodically...
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the
On Friday 19 September 2008, Felipe Balbi wrote:
+static struct platform_device *omap_wdt_dev;
+
...
+struct omap_wdt_dev {
+ void __iomem *base; /* physical */
+ struct device *dev;
You don't need both omap_wdt_dev (platform device)
and omap_wdt_dev.dev (hmm,
On Fri, Sep 19, 2008 at 01:23:38AM +0300, Felipe Balbi wrote:
From: Felipe Balbi [EMAIL PROTECTED]
These are changes that have been sitting in linux-omap
and were never sent upstream.
Hopefully, it'll never happen again at least for this
driver.
Great, thanks for looking at this.
On Fri, Sep 19, 2008 at 12:05:29AM +0100, Russell King - ARM Linux wrote:
On Fri, Sep 19, 2008 at 01:23:38AM +0300, Felipe Balbi wrote:
From: Felipe Balbi [EMAIL PROTECTED]
These are changes that have been sitting in linux-omap
and were never sent upstream.
Hopefully, it'll never
On Fri, Sep 19, 2008 at 02:11:20AM +0300, Felipe Balbi wrote:
On Fri, Sep 19, 2008 at 12:05:29AM +0100, Russell King - ARM Linux wrote:
On Fri, Sep 19, 2008 at 01:23:38AM +0300, Felipe Balbi wrote:
From: Felipe Balbi [EMAIL PROTECTED]
These are changes that have been sitting in
