Re: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread Arnd Bergmann
On Thursday 13 September 2012, AnilKumar Ch wrote: Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM lis331dlh accelerometer is connected to I2C2 bus. So this patch change the status to okay to use I2C2 bus. Also added all the required platform data to am335x-evm.

RE: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread AnilKumar, Chimata
Hi Arnd, Thanks for the review, On Fri, Sep 14, 2012 at 13:56:06, Arnd Bergmann wrote: On Thursday 13 September 2012, AnilKumar Ch wrote: Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM lis331dlh accelerometer is connected to I2C2 bus. So this patch change the status to

Re: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread Arnd Bergmann
On Friday 14 September 2012, AnilKumar, Chimata wrote: On Fri, Sep 14, 2012 at 13:56:06, Arnd Bergmann wrote: On Thursday 13 September 2012, AnilKumar Ch wrote: Why do you put the reg property here Here I specified reg property because lis331dlh I2C slave address is 0x18.

RE: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread AnilKumar, Chimata
+Daniel On Fri, Sep 14, 2012 at 15:58:37, Arnd Bergmann wrote: On Friday 14 September 2012, AnilKumar, Chimata wrote: On Fri, Sep 14, 2012 at 13:56:06, Arnd Bergmann wrote: On Thursday 13 September 2012, AnilKumar Ch wrote: Why do you put the reg property here Here I specified

Re: [PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-14 Thread Arnd Bergmann
On Friday 14 September 2012, AnilKumar, Chimata wrote: Small question here, in my v2 version I have specified both the compatible names lis3lv02d and lis331dlh is it fine or only one is sufficient? +static struct of_device_id lis3lv02d_i2c_dt_ids[] = { + { .compatible = st,lis3lv02d

[PATCH 2/2] ARM: dts: AM33XX: Add lis331dlh device tree data to am335x-evm

2012-09-13 Thread AnilKumar Ch
Add lis331dlh device tree data to am335x-evm.dts. In AM335x EVM lis331dlh accelerometer is connected to I2C2 bus. So this patch change the status to okay to use I2C2 bus. Also added all the required platform data to am335x-evm. Signed-off-by: AnilKumar Ch anilku...@ti.com ---