On Thu, Mar 05, 2009 at 11:32:31AM -0600, Lopez Cruz, Misael wrote:
Add headset jack detection for SDP3430 boards using SoC jack
reporting interface. Headset detection on SDP3430 board is
achieved through TWL4030 GPIO_2 pin.
Applied, thanks. One comment:
+/* Headset jack detection gpios */
Add headset jack detection for SDP3430 boards using SoC jack
reporting interface. Headset detection on SDP3430 board is
achieved through TWL4030 GPIO_2 pin.
Signed-off-by: Misael Lopez Cruz x0052...@ti.com
---
sound/soc/omap/sdp3430.c | 43 +--
1 files
Add headset jack detection for SDP3430 boards using SoC jack
reporting interface. Headset detection on SDP3430 board is
achieved through TWL4030 GPIO_2 pin.
Signed-off-by: Misael Lopez Cruz x0052...@ti.com
---
sound/soc/omap/sdp3430.c | 49 -
1 files
On Wed, Mar 04, 2009 at 11:39:12AM -0600, Lopez Cruz, Misael wrote:
+/* Headset jack */
+struct snd_soc_jack *hs_jack;
This (and all your other globals) should be declared static.
+/* Headset jack DAPM pins */
+struct snd_soc_jack_pin hs_jack_pins[] = {
+ {
+ .pin =
+ ret = snd_soc_jack_new(snd_soc_sdp3430, SDP3430 headset jack,
+ SND_JACK_HEADSET, hs_jack);
+ if (ret)
+ return ret;
This leaks the jack.
If hs_jack is declared as a direct static variable instead, then no mem
leaks, isn't it? Or do you mean to
