DISPLAY_SEL_GPIO and DLP_POWER_ON_GPIO are now handled in the .dts file,
so we can remove them from dss-common.c.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/dss-common.c | 21 -
1 file changed, 21 deletions(-)
diff --git
On 10/25/2013 05:07 AM, Tomi Valkeinen wrote:
DISPLAY_SEL_GPIO and DLP_POWER_ON_GPIO are now handled in the .dts file,
so we can remove them from dss-common.c.
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
arch/arm/mach-omap2/dss-common.c | 21 -
1 file
On 25/10/13 13:18, Nishanth Menon wrote:
void __init omap_4430sdp_display_init_of(void)
{
-int r;
-
-r = gpio_request_one(DISPLAY_SEL_GPIO, GPIOF_OUT_INIT_HIGH,
-display_sel);
-if (r)
-pr_err(%s: Could not get display_sel GPIO\n, __func__);
-
On 10/25/2013 05:25 AM, Tomi Valkeinen wrote:
On 25/10/13 13:18, Nishanth Menon wrote:
void __init omap_4430sdp_display_init_of(void)
{
- int r;
-
- r = gpio_request_one(DISPLAY_SEL_GPIO, GPIOF_OUT_INIT_HIGH,
- display_sel);
- if (r)
- pr_err(%s:
On 25/10/13 13:54, Nishanth Menon wrote:
would you not be depending on the weak IO pull done using mux to drive
these GPIO pins since the GPIO is not requested and held?
Yes. Is that not enough?
It depend on what the signal draw is and io drive strength which
varies - original intent of
On 10/25/2013 05:54 AM, Nishanth Menon wrote:
On 10/25/2013 05:25 AM, Tomi Valkeinen wrote:
On 25/10/13 13:18, Nishanth Menon wrote:
void __init omap_4430sdp_display_init_of(void)
{
- int r;
-
- r = gpio_request_one(DISPLAY_SEL_GPIO, GPIOF_OUT_INIT_HIGH,
-
On 25/10/13 14:14, Nishanth Menon wrote:
one additional angle before I forget - this is something we do as part
of power optimization - to identify pins which are programmed for a
pull in non-functional scenario as it has direct impact on idle power
numbers.
For example patch #3 in this
On 10/25/2013 06:13 AM, Tomi Valkeinen wrote:
On 25/10/13 13:54, Nishanth Menon wrote:
[..]
Could we not use Documentation/devicetree/bindings/gpio/gpio.txt
binding to map to the right GPIO and drive it using the GPIO module?
Hmm, what do you mean?
I do mux the pins to gpios, but there's
On 25/10/13 14:21, Nishanth Menon wrote:
The problem here is that the gpios don't really belong to anyone in the
kernel, as we don't have a driver for the switch.
Or did you mean that we'd still have the code in dss-common.c, but just
get the gpio numbers from the .dts instead? That makes
On 25/10/13 14:14, Nishanth Menon wrote:
lcd2_pins: pinmux_lcd2_pins {
+ pinctrl-single,pins =
+ 0x20 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* gpio_40 */
+ 0x46 (PIN_OUTPUT_PULLUP | MUX_MODE3)/* gpio_59 */
+ 0x56
On 10/25/2013 06:46 AM, Tomi Valkeinen wrote:
On 25/10/13 14:14, Nishanth Menon wrote:
lcd2_pins: pinmux_lcd2_pins {
+pinctrl-single,pins =
+0x20 (PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* gpio_40 */
+0x46 (PIN_OUTPUT_PULLUP | MUX_MODE3)/*
11 matches
Mail list logo
