Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware

2011-09-13 Thread Roedel, Joerg
On Wed, Sep 07, 2011 at 02:53:24PM -0400, Ohad Ben-Cohen wrote: drivers/iommu/amd_iommu.c | 20 ++- drivers/iommu/intel-iommu.c | 20 ++- drivers/iommu/iommu.c | 129 +++ drivers/iommu/msm_iommu.c |8 ++-

Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware

2011-09-13 Thread Ohad Ben-Cohen
Hi Joerg, On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Please split this patch into the core-change and patches for the individual iommu-drivers and post this as a seperate patch-set. But we'll be breaking bisectibility this way, no ? Intel IOMMU does not

Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware

2011-09-13 Thread Roedel, Joerg
On Tue, Sep 13, 2011 at 06:34:23AM -0400, Ohad Ben-Cohen wrote: Hi Joerg, On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Please split this patch into the core-change and patches for the individual iommu-drivers and post this as a seperate patch-set. But we'll

Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware

2011-09-13 Thread Ohad Ben-Cohen
On Tue, Sep 13, 2011 at 1:44 PM, Roedel, Joerg joerg.roe...@amd.com wrote: Not necessarily. You could implement this side-by-side with the old code until all drivers are converted and remove the old code then. This keeps bisectability. Ok. Intel IOMMU does not support arbitrary page-sizes,

[PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware

2011-09-07 Thread Ohad Ben-Cohen
When mapping a memory region, split it to page sizes as supported by the iommu hardware. Always prefer bigger pages, when possible, in order to reduce the TLB pressure. The logic to do that is now added to the IOMMU core, so neither the iommu drivers themselves nor users of the IOMMU API have to