Re: [PATCH 3/5] gic: Add set_type callback

2010-05-07 Thread Linus Walleij
2010/1/27 adhar...@codeaurora.org: From: Abhijeet Dharmapurikar adhar...@quicinc.com Add gic_set_type callback to set an irq as level or edge triggered type Abhijeet, will you pursue this patchset? Else we will pick it up and propose our solution for the U8500 needs which are similar.

[PATCH 3/5] gic: Add set_type callback

2010-01-27 Thread adharmap
From: Abhijeet Dharmapurikar adhar...@quicinc.com Add gic_set_type callback to set an irq as level or edge triggered type Signed-off-by: Abhijeet Dharmapurikar adhar...@quicinc.com --- arch/arm/common/gic.c | 43 +++ 1 files changed, 43 insertions(+), 0

Re: [PATCH 3/5] gic: Add set_type callback

2010-01-27 Thread Russell King - ARM Linux
On Wed, Jan 27, 2010 at 11:32:27AM -0800, adhar...@codeaurora.org wrote: + if (irq 1020) + return -1; *unprintable*. Always use proper error codes. + + /* + * Two bits each, calc the register and bit, 16 per 32 bit register + * accessible long word only +

Re: [PATCH 3/5] gic: Add set_type callback

2010-01-27 Thread Russell King - ARM Linux
On Wed, Jan 27, 2010 at 11:32:27AM -0800, adhar...@codeaurora.org wrote: + if (flow_type (IRQ_TYPE_EDGE_RISING|IRQ_TYPE_EDGE_FALLING)) { + reg_value |= (2bit_index); + writel(reg_value, gic_dist_base(irq) + GIC_DIST_CONFIG +

Re: [PATCH 3/5] gic: Add set_type callback

2010-01-27 Thread Abhijeet Dharmapurikar
Russell King - ARM Linux wrote: On Wed, Jan 27, 2010 at 11:32:27AM -0800, adhar...@codeaurora.org wrote: + if (flow_type (IRQ_TYPE_EDGE_RISING|IRQ_TYPE_EDGE_FALLING)) { + reg_value |= (2bit_index); + writel(reg_value, gic_dist_base(irq) + GIC_DIST_CONFIG +