On Tue, Jul 06, 2010 at 12:13:14PM +0300, Felipe Balbi wrote:
Hi,
On Thu, Jun 24, 2010 at 01:17:54PM +0200, ext Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
Hi,
On Thu, Jun 24, 2010 at 01:17:54PM +0200, ext Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
On Thu, Jul 08, 2010 at 07:23:44AM +0530, Gupta, Ajay Kumar wrote:
Hi,
On Thu, Jun 24, 2010 at 01:17:54PM +0200, ext Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
On Thu, Jun 24, 2010 at 03:10:01PM +0200, ext Sergei Shtylyov wrote:
@@ -714,12 +713,16 @@ static irqreturn_t musb_stage0_irq(struct musb
#ifdef CONFIG_USB_MUSB_OTG
/* flush endpoints when transitioning from Device Mode */
- if (is_peripheral_active(musb)) {
-
Hi,
On Thu, Jun 24, 2010 at 01:17:54PM +0200, ext Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Signed-off-by:
On Thu, Jun 17, 2010 at 12:40:36PM +0200, ext Ajay Kumar Gupta wrote:
+#ifdef CONFIG_USB_MUSB_HDRC_HCD
+ void __iomem*mbase = musb-mregs;
+#endif
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what
+#ifdef CONFIG_USB_MUSB_HDRC_HCD
+void __iomem*mbase = musb-mregs;
+#endif
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what needs
to be fixed,
or use musb-mregs directly.
This one seems to be a
Hello.
Gupta, Ajay Kumar wrote:
+#ifdef CONFIG_USB_MUSB_HDRC_HCD
+ void __iomem*mbase = musb-mregs;
+#endif
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what needs
to be fixed,
or use
then you add another ifdef to this file, which is already insane. I'd
rather see you either keep the local variables and just fix what needs
to be fixed,
or use musb-mregs directly.
This one seems to be a much better one. Copying the v-3 with this fix
below.
I don't see how
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Also removed definition of 'mbase' from multiple places to only
at function top.
Hello.
Ajay Kumar Gupta wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Also removed definition of 'mbase' from multiple places to
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Also removed definition of 'mbase' from multiple places to only
at function top.
Gupta, Ajay Kumar wrote:
Fixes below compilation warning when host only configuration is
selected.
drivers/usb/musb/musb_core.c: In function 'musb_stage0_irq':
drivers/usb/musb/musb_core.c:711: warning: unused variable 'mbase'
Also removed definition of 'mbase' from multiple places to only
AFAIR, it was intentionally removed from the function top and
declared
in the multiple plcase instead by the former Felipe's patch [1] to fix
exactly the same issue, if I don't mistake. So, it hasn't worked out?
Yes, it was removed by Felipe's below patch but it introduced
14 matches
Mail list logo
