Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-09 Thread Varadarajan, Charulatha
Kevin, On Wed, Mar 9, 2011 at 06:54, Varadarajan, Charulatha ch...@ti.com wrote: On Tue, Mar 8, 2011 at 13:23, Kevin Hilman khil...@ti.com wrote: On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-08 Thread Varadarajan, Charulatha
Kevin, On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops instead of sysdev_class. With this approach, gpio_bank_suspend() gpio_bank_resume() are not part of sys_dev_class. Usage

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-08 Thread Varadarajan, Charulatha
Kevin, On Tue, Mar 8, 2011 at 13:23, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: Kevin, On Tue, Mar 8, 2011 at 00:25, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-07 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: [...] GPIO driver is modified to use dev_pm_ops instead of sysdev_class. With this approach, gpio_bank_suspend() gpio_bank_resume() are not part of sys_dev_class. Usage of PM runtime get/put APIs in GPIO driver is as given below:

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-04 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get() Minor: I think you mean _get_sync() and _put() for enabling/disabling the clocks, sysconfig settings instead of using clock FW APIs. Note: OMAP16xx OMAP2 has interface and functional clocks

Re: [PATCH 5/5] OMAP: GPIO: use PM runtime framework

2011-03-04 Thread Varadarajan, Charulatha
Hi Kevin, Thanks for the detailed review. On Sat, Mar 5, 2011 at 03:29, Kevin Hilman khil...@ti.com wrote: Charulatha V ch...@ti.com writes: Call runtime pm APIs pm_runtime_put_sync() and pm_runtime_get() Minor: I think you mean _get_sync() and _put() Yes, thanks for catching it. It was a