Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-20 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 12/17/2010 04:54 PM, the following: Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 12/16/2010 12:57 PM, the following: Nishanth Menon n...@ti.com writes: Nishanth Menon had written, on 12/15/2010 06:05 PM, the

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-17 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 12/16/2010 12:57 PM, the following: Nishanth Menon n...@ti.com writes: Nishanth Menon had written, on 12/15/2010 06:05 PM, the following: Kevin Hilman had written, on 12/15/2010 05:47 PM, the following: I agree that this

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-17 Thread Nishanth Menon
Kevin Hilman had written, on 12/17/2010 04:54 PM, the following: Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 12/16/2010 12:57 PM, the following: Nishanth Menon n...@ti.com writes: Nishanth Menon had written, on 12/15/2010 06:05 PM, the following: Kevin Hilman had

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-16 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Nishanth Menon had written, on 12/15/2010 06:05 PM, the following: Kevin Hilman had written, on 12/15/2010 05:47 PM, the following: I agree that this additional check in sram_idle should be removed, but as long as I handle it in omap3_pm_off_mode_enable

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-16 Thread Nishanth Menon
Kevin Hilman had written, on 12/16/2010 12:57 PM, the following: Nishanth Menon n...@ti.com writes: Nishanth Menon had written, on 12/15/2010 06:05 PM, the following: Kevin Hilman had written, on 12/15/2010 05:47 PM, the following: I agree that this additional check in sram_idle should be

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-15 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 12/13/2010 09:42 PM, the following: Nishanth Menon n...@ti.com writes: Vishwanath Sripathy had written, on 12/13/2010 08:58 AM, the following: [...] diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach- omap2/pm34xx.c

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-15 Thread Nishanth Menon
Kevin Hilman had written, on 12/15/2010 05:47 PM, the following: I agree that this additional check in sram_idle should be removed, but as long as I handle it in omap3_pm_off_mode_enable where the next states are configured, is'nt that enough or am I missing something? Setting the next states

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-15 Thread Nishanth Menon
Nishanth Menon had written, on 12/15/2010 06:05 PM, the following: Kevin Hilman had written, on 12/15/2010 05:47 PM, the following: I agree that this additional check in sram_idle should be removed, but as long as I handle it in omap3_pm_off_mode_enable where the next states are configured,

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2 From: Eduardo Valentin eduardo.valen...@nokia.com Limitation i583: Self_Refresh Exit issue after OFF mode Issue: When device is waking up from OFF mode, then SDRC state machine sends inappropriate sequence violating JEDEC standards

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
; Kevin Hilman; Tony Lindgren; Nishanth Menon Subject: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2 From: Eduardo Valentin eduardo.valen...@nokia.com Limitation i583: Self_Refresh Exit issue after OFF mode Issue: When device is waking up from OFF mode, then SDRC state

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
Nishant, -Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Monday, December 13, 2010 7:13 PM To: Vishwanath Sripathy Cc: linux-omap; Eduardo Valentin; Kevin Hilman; Tony Lindgren Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2 Vishwanath Sripathy had written, on 12/13/2010 07:35 AM, the following: Nishant, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Nishanth Menon Sent: Friday

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
Nishant, -Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Monday, December 13, 2010 7:35 PM To: Vishwanath Sripathy Cc: linux-omap; Eduardo Valentin; Kevin Hilman; Tony Lindgren Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
Vishwanath Sripathy had written, on 12/13/2010 08:25 AM, the following: [...] + if (IS_PM34XX_ERRATUM(SDRC_WAKEUP_ERRATUM_i583) + (core_next_state == PWRDM_POWER_OFF)) { + pwrdm_set_next_pwrst(core_pwrdm, PWRDM_POWER_RET); +

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
-Original Message- Vishwanath Sripathy had written, on 12/13/2010 08:25 AM, the following: [...] + if (IS_PM34XX_ERRATUM(SDRC_WAKEUP_ERRATUM_i583) + (core_next_state == PWRDM_POWER_OFF)) { + pwrdm_set_next_pwrst(core_pwrdm,

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
Vishwanath Sripathy had written, on 12/13/2010 08:45 AM, the following: Keep in mind - if we disable it in omap3_pm_off_mode_enable - we will deny OFF wholesale if I understand the logic right- not just core-off - I kind of think that is extreme. No, I am not saying that deny idle for all

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
-Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Monday, December 13, 2010 8:14 PM To: Vishwanath Sripathy Cc: linux-omap; Eduardo Valentin; Kevin Hilman; Tony Lindgren Subject: RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
Nishant, -Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Monday, December 13, 2010 8:07 PM To: Vishwanath Sripathy Cc: linux-omap; Eduardo Valentin; Kevin Hilman; Tony Lindgren Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2 -Original Message- Vishwanath Sripathy had written, on 12/13/2010 08:25 AM, the following: [...] + if (IS_PM34XX_ERRATUM(SDRC_WAKEUP_ERRATUM_i583) + (core_next_state == PWRDM_POWER_OFF

RE: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Vishwanath Sripathy
-Original Message- From: Nishanth Menon [mailto:n...@ti.com] Sent: Monday, December 13, 2010 8:23 PM To: Vishwanath Sripathy Cc: linux-omap; Eduardo Valentin; Kevin Hilman; Tony Lindgren Subject: Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2 Vishwanath

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Nishanth Menon
Vishwanath Sripathy had written, on 12/13/2010 08:58 AM, the following: [...] diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach- omap2/pm34xx.c index ba3c0d6..da12a56 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -932,8 +932,15 @@ void

Re: [PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-13 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Vishwanath Sripathy had written, on 12/13/2010 08:58 AM, the following: [...] diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach- omap2/pm34xx.c index ba3c0d6..da12a56 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@

[PATCH 5/5 v3] OMAP3630: PM: Erratum i583: disable coreoff if ES1.2

2010-12-03 Thread Nishanth Menon
From: Eduardo Valentin eduardo.valen...@nokia.com Limitation i583: Self_Refresh Exit issue after OFF mode Issue: When device is waking up from OFF mode, then SDRC state machine sends inappropriate sequence violating JEDEC standards. Impact: OMAP3630 ES1.2 is impacted as follows depending on