On Mon, 15 Oct 2012, Paul Walmsley wrote:
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver to the mach-omap2 integration code. Instead, add a
temporary platform_data function pointer to
Hi,
On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver to the mach-omap2 integration code. Instead, add a
temporary platform_data
Terve,
On Thu, 25 Oct 2012, Aaro Koskinen wrote:
On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver to the mach-omap2 integration
* Paul Walmsley p...@pwsan.com [121025 11:53]:
Terve,
On Thu, 25 Oct 2012, Aaro Koskinen wrote:
On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it
On Thu, 25 Oct 2012, Tony Lindgren wrote:
Ideally we'd have some Linux generic function to implement in the PRM/CM
drivers for getting the bootreason. But I guess we don't?
Do you know of one, apart from WDIOC_GETBOOTSTATUS?
- Paul
--
To unsubscribe from this list: send the line unsubscribe
* Paul Walmsley p...@pwsan.com [121025 12:11]:
On Thu, 25 Oct 2012, Tony Lindgren wrote:
Ideally we'd have some Linux generic function to implement in the PRM/CM
drivers for getting the bootreason. But I guess we don't?
Do you know of one, apart from WDIOC_GETBOOTSTATUS?
I wonder if we
On Thu, 25 Oct 2012, Tony Lindgren wrote:
I wonder if we can now with multiple watchdogs supported to
have also PRM/CM implement omap_prcm_wdt_ioctl() that just
handles WDIOC_GETBOOTSTATUS and then just remove that handling
from the other omap watchdog drivers?
The watchdog ioctl code needs
* Paul Walmsley p...@pwsan.com [121025 12:32]:
On Thu, 25 Oct 2012, Tony Lindgren wrote:
I wonder if we can now with multiple watchdogs supported to
have also PRM/CM implement omap_prcm_wdt_ioctl() that just
handles WDIOC_GETBOOTSTATUS and then just remove that handling
from the other
* Tony Lindgren t...@atomide.com [121025 12:35]:
* Paul Walmsley p...@pwsan.com [121025 12:32]:
On Thu, 25 Oct 2012, Tony Lindgren wrote:
I wonder if we can now with multiple watchdogs supported to
have also PRM/CM implement omap_prcm_wdt_ioctl() that just
handles
On Thu, 25 Oct 2012, Tony Lindgren wrote:
I have not looked how the watchdog subsystem handles multiple
watchdogs, but..
In the new watchdog core code, each watchdog driver gets a separate
/dev/watchdog* character device. The ioctls are called on those device
nodes.
[ As an aside, neither
Hi,
On Thu, Oct 25, 2012 at 07:57:31PM +, Paul Walmsley wrote:
[ As an aside, neither the OMAP watchdog driver, nor the TWL watchdog
driver have been updated to use the new watchdog core code. So they both
can't be loaded at the same time until one or both are fixed. ]
FYI, this is
On Thu, 25 Oct 2012, Aaro Koskinen wrote:
On Thu, Oct 25, 2012 at 07:57:31PM +, Paul Walmsley wrote:
[ As an aside, neither the OMAP watchdog driver, nor the TWL watchdog
driver have been updated to use the new watchdog core code. So they both
can't be loaded at the same time until
Hi Wim,
On Tue, 23 Oct 2012, Wim Van Sebroeck wrote:
When you have the opportunity, could you take a look at this patch, and
the subsequent patch 6/7, and ack them if you're okay with them?
Signed them off, Acked-by would probably have been better :-).
Great! Will add your Acked-by:s.
Hi Paul,
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver to the mach-omap2 integration code. Instead, add a
temporary platform_data function pointer to abstract this function
call. A
Hi Paul,
When you have the opportunity, could you take a look at this patch, and
the subsequent patch 6/7, and ack them if you're okay with them?
Signed them off, Acked-by would probably have been better :-).
We'd like to merge thse as part of a larger cleanup series through the
arm-soc
Sebroeck w...@iguana.be, linux-watch...@vger.kernel.org
Subject: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata
function pointer
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver
The OMAP watchdog timer driver directly calls a function exported by
code in arch/arm/mach-omap2. This is not good; it tightly couples
this driver to the mach-omap2 integration code. Instead, add a
temporary platform_data function pointer to abstract this function
call. A subsequent patch will
17 matches
Mail list logo
