Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver would have to know the the IP-specific

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Tomi Valkeinen
On 2012-10-25 17:31, Ricardo Neri wrote: On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-25 Thread Ricardo Neri
On 10/25/2012 09:54 AM, Tomi Valkeinen wrote: On 2012-10-25 17:31, Ricardo Neri wrote: On 10/23/2012 11:29 PM, Tomi Valkeinen wrote: On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio driver can't use them, and so they aren't really

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 04:37 AM, Tomi Valkeinen wrote: On 2012-10-23 03:48, Ricardo Neri wrote: +#if defined(CONFIG_OMAP4_DSS_HDMI_AUDIO) +#define HDMI_AUDIO_MEM_RESOURCE 0 +#define HDMI_AUDIO_DMA_RESOURCE 1 I don't see much point with these definitions. They are hdmi.c internal, so the audio

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm, so the audio side only needs the address of one

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Ricardo Neri
On 10/23/2012 11:17 AM, Tomi Valkeinen wrote: On 2012-10-23 18:42, Ricardo Neri wrote: What registers does the audio side need to access? It only needs access to the DMA audio data port. All other operations that the audio driver needs are done through the omapdss audio interface. Hmm,

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-23 Thread Tomi Valkeinen
On 2012-10-23 20:21, Ricardo Neri wrote: If so, you could pass only that one address, instead of the whole HDMI register space? Yes, that could work. I thought about that but the common HDMI driver would have to know the the IP-specific register, which it should not. Argh, of course...

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-22 Thread Tomi Valkeinen
On 2012-10-16 04:27, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow the design of drivers such as MFD, in which a single entity handles the creation of

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-22 Thread Ricardo Neri
Hi Tomi, Thanks for reviewing! On 10/22/2012 02:40 AM, Tomi Valkeinen wrote: On 2012-10-16 04:27, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow the

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-16 Thread Péter Ujfalusi
On 10/16/2012 03:27 AM, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow the design of drivers such as MFD, in which a single entity handles the creation

Re: [PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-16 Thread Ricardo Neri
Hi Peter, Thanks for reviewing! On 10/16/2012 04:30 AM, Péter Ujfalusi wrote: On 10/16/2012 03:27 AM, Ricardo Neri wrote: Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow

[PATCH 6/6] OMAPDSS: HDMI: Create platform device to support audio

2012-10-15 Thread Ricardo Neri
Creating the accessory devices, such as audio, from the HDMI driver allows to regard HDMI as a single entity with audio an display functionality. This intends to follow the design of drivers such as MFD, in which a single entity handles the creation of the accesory devices. Such devices are then