Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

2015-01-23 Thread Tomeu Vizoso
On 01/22/2015 07:59 PM, Stephen Boyd wrote: On 01/22, Tomeu Vizoso wrote: On 01/22/2015 02:01 AM, Stephen Boyd wrote: BTW, please try and fixup checkpatch warnings. What were you thinking of specifically? I'm running it with --max-line-length=106 and the other warnings are in clk-test.c that

Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

2015-01-22 Thread Tomeu Vizoso
On 01/22/2015 02:01 AM, Stephen Boyd wrote: On 01/21, Tomeu Vizoso wrote: @@ -2075,10 +2210,12 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw) } } -ret = __clk_init(dev, clk); +hw-clk = __clk_create_clk(hw, NULL, NULL); +ret =

Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

2015-01-22 Thread Stephen Boyd
On 01/22, Tomeu Vizoso wrote: On 01/22/2015 02:01 AM, Stephen Boyd wrote: BTW, please try and fixup checkpatch warnings. What were you thinking of specifically? I'm running it with --max-line-length=106 and the other warnings are in clk-test.c that I still have to polish when I get some

Re: [PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

2015-01-21 Thread Stephen Boyd
On 01/21, Tomeu Vizoso wrote: @@ -2075,10 +2210,12 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw) } } - ret = __clk_init(dev, clk); + hw-clk = __clk_create_clk(hw, NULL, NULL); + ret = __clk_init(dev, hw-clk); if (!ret) -

[PATCH v11 2/4] clk: Make clk API return per-user struct clk instances

2015-01-21 Thread Tomeu Vizoso
Moves clock state to struct clk_core, but takes care to change as little API as possible. struct clk_hw still has a pointer to a struct clk, which is the implementation's per-user clk instance, for backwards compatibility. The struct clk that clk_get_parent() returns isn't owned by the caller,