Re: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-10-19 Thread Benoit Cousson
Hi Avinash, This look good to me except the: status = disabled. The disabled should be reserved for variant that does not contain the IP. Is it the case here? Regards, Benoit On 09/18/2012 07:30 AM, Philip, Avinash wrote: Add McSPI data node to AM33XX device tree file. The McSPI module (and

RE: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-10-19 Thread Philip, Avinash
On Fri, Oct 19, 2012 at 13:54:15, Cousson, Benoit wrote: Hi Avinash, This look good to me except the: status = disabled. status = disabled in soc .dtsi file to make sure that IP driver won't loaded unless if IP used. So from board .dts file status = okay should be set if IP being used.

Re: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-10-19 Thread Matt Porter
On Fri, Oct 19, 2012 at 10:24:15AM +0200, Benoit Cousson wrote: Hi Avinash, This look good to me except the: status = disabled. The disabled should be reserved for variant that does not contain the IP. Is it the case here? http://comments.gmane.org/gmane.linux.drivers.devicetree/18968 is

Re: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-10-19 Thread Benoit Cousson
Hi Matt, On 10/19/2012 01:30 PM, Matt Porter wrote: On Fri, Oct 19, 2012 at 10:24:15AM +0200, Benoit Cousson wrote: Hi Avinash, This look good to me except the: status = disabled. The disabled should be reserved for variant that does not contain the IP. Is it the case here?

Re: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-10-19 Thread Matt Porter
On Fri, Oct 19, 2012 at 02:40:58PM +0200, Benoit Cousson wrote: Hi Matt, On 10/19/2012 01:30 PM, Matt Porter wrote: On Fri, Oct 19, 2012 at 10:24:15AM +0200, Benoit Cousson wrote: Hi Avinash, This look good to me except the: status = disabled. The disabled should be reserved for

RE: [PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-09-26 Thread Philip, Avinash
Hi Benoit, On Tue, Sep 18, 2012 at 11:00:28, Philip, Avinash wrote: Add McSPI data node to AM33XX device tree file. The McSPI module (and so as the driver) is reused from OMAP4. Signed-off-by: Philip, Avinash avinashphi...@ti.com Tested-by: Matt Porter mpor...@ti.com I haven't

[PATCH v2] arm/dts: AM33XX: Add SPI device tree data

2012-09-17 Thread Philip, Avinash
Add McSPI data node to AM33XX device tree file. The McSPI module (and so as the driver) is reused from OMAP4. Signed-off-by: Philip, Avinash avinashphi...@ti.com Tested-by: Matt Porter mpor...@ti.com --- Changes since v1: - Corrected reg offset in reg DT entry. :100644 100644 ff3badb...