Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-18 Thread Russell King - ARM Linux
On Mon, Sep 17, 2012 at 08:43:57AM +0530, Vinod Koul wrote: On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: - /* FIXME: not supported by platform private API */ - return -EINVAL; + /* Pause/Resume only allowed with cyclic mode */ + if (!c-cyclic) +

Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-17 Thread Peter Ujfalusi
Hi Vinod, On 09/17/2012 06:13 AM, Vinod Koul wrote: On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: - /* FIXME: not supported by platform private API */ - return -EINVAL; + /* Pause/Resume only allowed with cyclic mode */ + if (!c-cyclic) +

Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-17 Thread Vinod Koul
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA. This method has been used for years on OMAP based products. We only allow pause/resume when the DMA has been configured in cyclic mode which is used by the

Re: [PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-16 Thread Vinod Koul
On Fri, 2012-09-14 at 15:05 +0300, Peter Ujfalusi wrote: - /* FIXME: not supported by platform private API */ - return -EINVAL; + /* Pause/Resume only allowed with cyclic mode */ + if (!c-cyclic) + return -EINVAL; This is not a dma restriction right? --

[PATCH v3 02/15] dmaengine: omap: Add support for pause/resume in cyclic dma mode

2012-09-14 Thread Peter Ujfalusi
The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA. This method has been used for years on OMAP based products. We only allow pause/resume when the DMA has been configured in cyclic mode which is used by the audio stack. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com