Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:22PM +0530, Rajendra Nayak wrote: + min_uV = of_get_property(np, regulator-min-uV, NULL); + if (min_uV) + (*init_data)-constraints.min_uV = be32_to_cpu(*min_uV); + max_uV = of_get_property(np, regulator-max-uV, NULL); + if (max_uV) +

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Nayak, Rajendra
If we have min_uV and max_uV we should also set REGULATOR_CHANGE_VOLTAGE (and similarly for the currents). We should also have a way to enable status changes - since there's an always_on property (which does make sense) I'd suggest that as a first pass we should enable status changes if

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 04:13:08PM +0530, Nayak, Rajendra wrote: okay, here's an updated patch which does that. I also added a binding to specify a descriptive name to the regulator outputs as you suggested in the other thread. Looks good! I guess we may run into issues with the status

Re: [PATCH v3 1/4] regulator: helper routine to extract regulator_init_data

2011-10-27 Thread Rajendra Nayak
On Thursday 27 October 2011 05:19 PM, Mark Brown wrote: On Thu, Oct 27, 2011 at 04:13:08PM +0530, Nayak, Rajendra wrote: okay, here's an updated patch which does that. I also added a binding to specify a descriptive name to the regulator outputs as you suggested in the other thread. Looks