Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-17 Thread Brian Norris
Hi, On Tue, Nov 17, 2015 at 12:02:29PM +0530, Vignesh R wrote: > On 11/13/2015 09:35 PM, Cyrille Pitchen wrote: > > > > In September I've sent a series of patches to enhance the support of QSPI > > flash > > memories. Patch 4 was dedicated to the m25p80 driver and set the > > rx_nbits /

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-16 Thread Vignesh R
Hi Brian, On 11/13/2015 09:35 PM, Cyrille Pitchen wrote: [...] > > In September I've sent a series of patches to enhance the support of QSPI > flash > memories. Patch 4 was dedicated to the m25p80 driver and set the > rx_nbits / tx_nbits fields of spi_transfer struct(s) in order to configure

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-13 Thread Cyrille Pitchen
Hi Brian, Le 11/11/2015 08:20, Brian Norris a écrit : > Hi, > > On Wed, Nov 11, 2015 at 12:20:46PM +0530, R, Vignesh wrote: >> On 11/11/2015 4:53 AM, Brian Norris wrote: >>> On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: diff --git a/include/linux/spi/spi.h

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-13 Thread Mike Looijmans
On 11-11-15 07:50, R, Vignesh wrote: Hi Brain, On 11/11/2015 4:53 AM, Brian Norris wrote: Hi Vignesh, ... Also, this API doesn't actually have anything to do with memory mapping. It has to do with the de facto standard flash protocol. So I don't think mmap belongs in the name; it should be

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-11 Thread Vignesh R
Hi Brian, On 11/12/2015 12:54 AM, Brian Norris wrote: > In addition to my other comments: > [...] >> +int (*spi_mtd_mmap_read)(struct spi_device *spi, >> + loff_t from, size_t len, >> + size_t *retlen, u_char *buf, >> +

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-11 Thread Brian Norris
In addition to my other comments: On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > In addition to providing direct access to SPI bus, some spi controller > hardwares (like ti-qspi) provide special memory mapped port > to accesses SPI flash devices in order to increase read

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-10 Thread Brian Norris
Hi, On Wed, Nov 11, 2015 at 12:20:46PM +0530, R, Vignesh wrote: > On 11/11/2015 4:53 AM, Brian Norris wrote: > > On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > >> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > >> index cce80e6dc7d1..2f2c431b8917 100644Hi > >> ---

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-10 Thread R, Vignesh
Hi Brain, On 11/11/2015 4:53 AM, Brian Norris wrote: > Hi Vignesh, > > Sorry for the late review. I did not have time to review much back when > you submitted your first RFCs for this. > > On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: >> diff --git a/include/linux/spi/spi.h

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-10 Thread Brian Norris
Hi Vignesh, Sorry for the late review. I did not have time to review much back when you submitted your first RFCs for this. On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > index cce80e6dc7d1..2f2c431b8917 100644 > ---

[PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-09 Thread Vignesh R
In addition to providing direct access to SPI bus, some spi controller hardwares (like ti-qspi) provide special memory mapped port to accesses SPI flash devices in order to increase read performance. This means the controller can automatically send the SPI signals required to read data from the