Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-06 Thread Rajendra Nayak
+- regulator-fixed-gpio: gpio to use for enable control +- regulator-fixed-startup-delay: startup time in microseconds startup-delay-ms ? ok. +- regulator-fixed-enable-high: Polarity of enable GPIO, + 1 = Active High, 0 = Active low Some gpio specifiers allow you to specify active

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Thu, Oct 27, 2011 at 01:26:23PM +0530, Rajendra Nayak wrote: The fixed regulator driver uses of_get_fixed_voltage_config() to extract fixed_voltage_config structure contents from device tree. Also add documenation for additional bindings for fixed regulators that can be passed through dt.

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 01:34:22PM -0700, Olof Johansson wrote: Shouldn't a fixed regulator just be a subset of a fixed one? If so, should the binding be merged with that one? No, the fixed voltage regultor is a superset of a general regulator - it has additional information like the voltage

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: On Fri, Nov 04, 2011 at 01:34:22PM -0700, Olof Johansson wrote: Shouldn't a fixed regulator just be a subset of a fixed one? If so, should the binding be merged with that one? No, the fixed voltage regultor is a superset of a

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:18:24PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: No, the fixed voltage regultor is a superset of a general regulator - it has additional information like the voltage it supplies and the optional enable GPIO.

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:18:24PM -0700, Olof Johansson wrote: On Fri, Nov 04, 2011 at 09:01:52PM +, Mark Brown wrote: No, the fixed voltage regultor is a superset of a general regulator - it has

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 02:47:05PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown I don't see how you can usefully do that, the task of plumbing a regulator into a board is largely orthogonal to the specific feature set of a given regulator.  The specific bindings

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Olof Johansson
On Fri, Nov 4, 2011 at 2:57 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Nov 04, 2011 at 02:47:05PM -0700, Olof Johansson wrote: On Fri, Nov 4, 2011 at 2:25 PM, Mark Brown I don't see how you can usefully do that, the task of plumbing a regulator into a board is largely

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-11-04 Thread Mark Brown
On Fri, Nov 04, 2011 at 03:09:32PM -0700, Olof Johansson wrote: But even things like allowing (optional) attributes such as startup-delay on non-fixed regulators could make sense. Keep in mind that the device tree should focus on describing the hardware, not just what the linux driver needs

Re: [PATCH v3 2/4] regulator: adapt fixed regulator driver to dt

2011-10-27 Thread Mark Brown
On Thu, Oct 27, 2011 at 01:26:23PM +0530, Rajendra Nayak wrote: The fixed regulator driver uses of_get_fixed_voltage_config() to extract fixed_voltage_config structure contents from device tree. Also add documenation for additional bindings for fixed regulators that can be passed through dt.