Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Tony Lindgren
Hi Mike, * Greg KH g...@kroah.com [22 10:51]: On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote: Ah, comments like this warm my heart. Come on, no abusing the kobject code please, if have problems with how the kernel core works, and it doesn't do things you want it

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2011 at 08:59:04AM -0800, Tony Lindgren wrote: ..let's plan on getting rid of the early usage of clocks instead so you don't have the issue of deferring stuff. No - we have too many platforms already using them early to do a change like this - and to do such a change will force

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]: On Wed, Nov 23, 2011 at 08:59:04AM -0800, Tony Lindgren wrote: ..let's plan on getting rid of the early usage of clocks instead so you don't have the issue of deferring stuff. No - we have too many platforms already using

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Mark Brown
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]: Keep the clk API as a fundamental thing which should be initialized early so we don't have to invent new clk APIs to get around its unavailability. What else are

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Tony Lindgren
* Mark Brown broo...@opensource.wolfsonmicro.com [23 10:34]: On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [23 09:31]: Keep the clk API as a fundamental thing which should be initialized early so we don't have to

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Turquette, Mike
On Tue, Nov 22, 2011 at 7:48 PM, Saravana Kannan skan...@codeaurora.org wrote: On 11/22/2011 11:13 AM, Greg KH wrote: On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote: Ah, comments like this warm my heart. Come on, no abusing the kobject code please, if have problems with how

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Russell King - ARM Linux
On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote: What else are you aware of that is really needed early for clocks other than clockevent? TWD will lose its auto-calibration. Then there's various clock source and clock event implementations. These all call for the clk API to be

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [23 14:07]: On Wed, Nov 23, 2011 at 10:55:19AM -0800, Tony Lindgren wrote: What else are you aware of that is really needed early for clocks other than clockevent? TWD will lose its auto-calibration. Then there's various clock source

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Arnd Bergmann
On Tuesday 22 November 2011, Mike Turquette wrote: Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also adds support for generating the clk tree in clk_init and migrating nodes when input sources

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Greg KH
On Mon, Nov 21, 2011 at 05:40:47PM -0800, Mike Turquette wrote: Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also adds support for generating the clk tree in clk_init and migrating nodes when

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Mike Turquette
On Tue, Nov 22, 2011 at 5:07 AM, Arnd Bergmann arnd.bergm...@linaro.org wrote: On Tuesday 22 November 2011, Mike Turquette wrote: Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also adds support for

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Mike Turquette
On Tue, Nov 22, 2011 at 7:49 AM, Greg KH g...@kroah.com wrote: On Mon, Nov 21, 2011 at 05:40:47PM -0800, Mike Turquette wrote: Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also adds support for

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Mike Turquette
On Tue, Nov 22, 2011 at 8:37 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Nov 21, 2011 6:43 PM, Mike Turquette mturque...@ti.com wrote: Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote: Ah, comments like this warm my heart. Come on, no abusing the kobject code please, if have problems with how the kernel core works, and it doesn't do things you want it to, then why not change it to work properly for you, or

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Grant Likely
On Tue, Nov 22, 2011 at 11:01 AM, Mike Turquette mturque...@linaro.org wrote: On Tue, Nov 22, 2011 at 8:37 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Nov 21, 2011 6:43 PM, Mike Turquette mturque...@ti.com wrote: Introduces kobject support for the common struct clk, exports per-clk

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Arnd Bergmann
On Tuesday 22 November 2011 12:19:51 Grant Likely wrote: On Tue, Nov 22, 2011 at 11:01 AM, Mike Turquette mturque...@linaro.org wrote: Others have requested to have knobs made available for actually performing clk_enable/clk_disable and even clk_set_rate from userspace. I hate this idea

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Turquette, Mike
On Tue, Nov 22, 2011 at 12:02 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 22 November 2011 12:19:51 Grant Likely wrote: On Tue, Nov 22, 2011 at 11:01 AM, Mike Turquette mturque...@linaro.org wrote: Others have requested to have knobs made available for actually performing

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-22 Thread Saravana Kannan
On 11/22/2011 11:13 AM, Greg KH wrote: On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote: Ah, comments like this warm my heart. Come on, no abusing the kobject code please, if have problems with how the kernel core works, and it doesn't do things you want it to, then why not

[PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-21 Thread Mike Turquette
Introduces kobject support for the common struct clk, exports per-clk data via read-only callbacks and models the clk tree topology in sysfs. Also adds support for generating the clk tree in clk_init and migrating nodes when input sources are switches in clk_set_parent. Signed-off-by: Mike