Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Krishnamoorthy, Balaji T
snip -               if (cpu_is_omap44xx()) -                       mmc-reg_offset = OMAP4_MMC_REG_OFFSET; -               else -                       mmc-reg_offset = 0; +static struct omap_mmc_platform_data *mmc __initdata; can you pass this *mmc as another argument to

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kadiyala, Kishore
On Fri, Feb 25, 2011 at 6:20 PM, Krishnamoorthy, Balaji T balaj...@ti.com wrote: snip -               if (cpu_is_omap44xx()) -                       mmc-reg_offset = OMAP4_MMC_REG_OFFSET; -               else -                       mmc-reg_offset = 0; +static struct omap_mmc_platform_data

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-25 Thread Kadiyala, Kishore
On Fri, Feb 25, 2011 at 5:02 AM, Tony Lindgren t...@atomide.com wrote: * Kishore Kadiyala kishore.kadiy...@ti.com [110224 11:17]: Changes involves: 1) Remove controller reset in devices.c which is taken care of    by hwmod framework. 2) Omap2420 platform consists of mmc block as in omap1 and

[PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Kishore Kadiyala
Changes involves: 1) Remove controller reset in devices.c which is taken care of by hwmod framework. 2) Omap2420 platform consists of mmc block as in omap1 and not the hsmmc block as present in omap2430, omap3, omap4 platforms. Removing all base address macro defines except keeping one

Re: [PATCH v4 5/6] OMAP: adapt hsmmc to hwmod framework

2011-02-24 Thread Tony Lindgren
* Kishore Kadiyala kishore.kadiy...@ti.com [110224 11:17]: Changes involves: 1) Remove controller reset in devices.c which is taken care of by hwmod framework. 2) Omap2420 platform consists of mmc block as in omap1 and not the hsmmc block as present in omap2430, omap3, omap4 platforms.