Hi Samuel,
On Monday 04 July 2011 19:39:35 Samuel Ortiz wrote:
That is fine with me, yes. That's why I ACK the MFD patches for Tony to take
them.
I have changed the series for Tony in my branch for the following comments:
wl6040_is_powered, twl6040_get_rev removal, since these are really small
Hi Peter,
On Tue, Jun 21, 2011 at 04:39:06PM +0300, Peter Ujfalusi wrote:
+int twl6040_is_powered(struct twl6040 *twl6040)
+{
+ return twl6040-power_count;
+}
+EXPORT_SYMBOL(twl6040_is_powered);
Do we really need to export this one ?
+static inline int twl6040_get_rev(struct twl6040
hi,
On Tue, Jun 21, 2011 at 04:39:06PM +0300, Peter Ujfalusi wrote:
+static int __devinit twl6040_probe(struct platform_device *pdev)
+{
+ struct twl4030_audio_data *pdata = pdev-dev.platform_data;
+ struct twl6040 *twl6040;
+ struct mfd_cell *cell = NULL;
+ int ret,
Hi Felipe, Samuel,
On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
+ ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
+ twl6040_naudint_handler, 0,
+ twl6040_irq_ready, twl6040);
why don't you use
Hi Samuel,
On Monday 04 July 2011 13:48:44 Samuel Ortiz wrote:
Hi Peter,
On Tue, Jun 21, 2011 at 04:39:06PM +0300, Peter Ujfalusi wrote:
+int twl6040_is_powered(struct twl6040 *twl6040)
+{
+ return twl6040-power_count;
+}
+EXPORT_SYMBOL(twl6040_is_powered);
Do we really need to
Hi,
On Mon, Jul 04, 2011 at 04:09:30PM +0300, Péter Ujfalusi wrote:
Hi Felipe, Samuel,
On Monday 04 July 2011 14:53:30 Balbi, Felipe wrote:
+ ret = twl6040_request_irq(twl6040, TWL6040_IRQ_READY,
+ twl6040_naudint_handler, 0,
+
Hi Samuel,
On Monday 04 July 2011 13:48:44 Samuel Ortiz wrote:
I don't see the value of those 3 inline functions. Removing them would make
the code actually more understandable (especially for the 2nd one).
Is it OK for you if I fix these as a follow-up series, so I do not need to
rewrite
Hi Peter,
On Mon, Jul 04, 2011 at 05:08:17PM +0300, Péter Ujfalusi wrote:
Hi Samuel,
On Monday 04 July 2011 13:48:44 Samuel Ortiz wrote:
I don't see the value of those 3 inline functions. Removing them would make
the code actually more understandable (especially for the 2nd one).
Is it
From: Misael Lopez Cruz misael.lo...@ti.com
TWL6040 IC provides analog high-end audio codec functions for
handset applications. It contains several audio analog inputs
and outputs as well as vibrator support. It's connected to the
host processor via PDM interface for audio data communication.
The
