Re: [PATCHv2 1/7] pwm: Add pwm core driver

2010-10-06 Thread Kevin Hilman
Arun MURTHY arun.mur...@stericsson.com writes: [...] I suggest that you work on Kevin's comments before making any code changes though. This pwm driver also supports the Davinci pwm driver as suggested by Kelvin. My concern isn't whether it supports davinci or not. Adapting existing

[PATCHv2 1/7] pwm: Add pwm core driver

2010-10-05 Thread Arun Murthy
The existing pwm based led and backlight driver makes use of the pwm(include/linux/pwm.h). So all the board specific pwm drivers will be exposing the same set of function name as in include/linux/pwm.h. Consder a platform with multi Soc or having more than one pwm module, in such a case, there

Re: [PATCHv2 1/7] pwm: Add pwm core driver

2010-10-05 Thread Andrew Morton
On Tue, 5 Oct 2010 17:29:56 +0530 Arun Murthy arun.mur...@stericsson.com wrote: The existing pwm based led and backlight driver makes use of the pwm(include/linux/pwm.h). So all the board specific pwm drivers will be exposing the same set of function name as in include/linux/pwm.h. Consder a

RE: [PATCHv2 1/7] pwm: Add pwm core driver

2010-10-05 Thread Arun MURTHY
On Tue, 5 Oct 2010 17:29:56 +0530 Arun Murthy arun.mur...@stericsson.com wrote: The existing pwm based led and backlight driver makes use of the pwm(include/linux/pwm.h). So all the board specific pwm drivers will be exposing the same set of function name as in include/linux/pwm.h.