Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-14 Thread Todd Poynor
On Wed, Jul 13, 2011 at 05:00:35PM +0300, Tero Kristo wrote: OMAP SMPS regulator driver provides access to OMAP voltage processor controlled regulators. These include VDD1 and VDD2 for OMAP3 and additionally VDD3 for OMAP4. SMPS regulators use the OMAP voltage layer for the actual voltage

Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-14 Thread Tero Kristo
On Thu, 2011-07-14 at 08:29 +0200, Todd Poynor wrote: On Wed, Jul 13, 2011 at 05:00:35PM +0300, Tero Kristo wrote: OMAP SMPS regulator driver provides access to OMAP voltage processor controlled regulators. These include VDD1 and VDD2 for OMAP3 and additionally VDD3 for OMAP4. SMPS

Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-14 Thread Tero Kristo
On Thu, 2011-07-14 at 00:55 +0200, Mark Brown wrote: On Wed, Jul 13, 2011 at 06:53:45PM +0300, Tero Kristo wrote: On Wed, 2011-07-13 at 16:40 +0200, Mark Brown wrote: I do strongly prefer the idiom of just registering all the regulators even if they're read only. Number of available

[PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-13 Thread Tero Kristo
OMAP SMPS regulator driver provides access to OMAP voltage processor controlled regulators. These include VDD1 and VDD2 for OMAP3 and additionally VDD3 for OMAP4. SMPS regulators use the OMAP voltage layer for the actual voltage regulation operations. Signed-off-by: Tero Kristo t-kri...@ti.com

Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-13 Thread Mark Brown
On Wed, Jul 13, 2011 at 05:00:35PM +0300, Tero Kristo wrote: +config REGULATOR_OMAP_SMPS + tristate TI OMAP SMPS Power Regulators + depends on (ARCH_OMAP3 || ARCH_OMAP4) PM TWL4030_CORE What is the dependency on the TWL4030? I see no references to it in the code... + for (i =

Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-13 Thread Tero Kristo
On Wed, 2011-07-13 at 16:40 +0200, Mark Brown wrote: On Wed, Jul 13, 2011 at 05:00:35PM +0300, Tero Kristo wrote: +config REGULATOR_OMAP_SMPS + tristate TI OMAP SMPS Power Regulators + depends on (ARCH_OMAP3 || ARCH_OMAP4) PM TWL4030_CORE What is the dependency on the TWL4030? I

Re: [PATCHv2 2/5] regulator: omap smps regulator driver

2011-07-13 Thread Mark Brown
On Wed, Jul 13, 2011 at 06:53:45PM +0300, Tero Kristo wrote: On Wed, 2011-07-13 at 16:40 +0200, Mark Brown wrote: I do strongly prefer the idiom of just registering all the regulators even if they're read only. Number of available SMPS regulators is kind of board specific issue. OMAP3 has