Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-25 Thread Mark Brown
On Wed, Feb 24, 2010 at 03:43:14PM -0600, Olaya, Margarita wrote: [Reflowed into 80 columns] I'll re-submit the patch series using twl6040_codec instead of twl6030_codec, twl6030 is the power companion chip and twl4030 is the audio chip, so in the case of this patch should I send an

Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Liam Girdwood
On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: From: Misael Lopez Cruz x0052...@ti.com In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data structure. For twl6030 audio codec, the following data may be passed: -

Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Samuel Ortiz
Hi Liam, On Wed, Feb 24, 2010 at 10:09:29AM +, Liam Girdwood wrote: On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote: From: Misael Lopez Cruz x0052...@ti.com In order to have TWL6030 CODEC driver as a platform driver, codec data should be passed through twl_platform_data

Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Mark Brown
On Wed, Feb 24, 2010 at 12:13:29PM +0100, Samuel Ortiz wrote: Samuel are you OK with this ? That seems fine, yes. Acked-by: Samuel Ortiz sa...@linux.intel.com OK, I've applied this one now - the cross tree issues mean it seems better to get into 2.6.34. I'll review the rest of the patches

RE: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Olaya, Margarita
[mailto:broo...@opensource.wolfsonmicro.com] Sent: Wednesday, February 24, 2010 7:23 AM To: Samuel Ortiz Cc: Liam Girdwood; Olaya, Margarita; alsa-de...@alsa-project.org; linux-omap@vger.kernel.org Subject: Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec On Wed, Feb 24, 2010

RE: [alsa-devel] [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec

2010-02-24 Thread Misael Lopez
contains PM, USB, I2C, etc - TWL6040 contains only audio Then, TWL6030 is the MFD and TWL6040 is a simple audio codec, and this patch ([PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec) is not valid since the codec doesn't belong to the MFD anymore. TWL6040 can become a MFD to support