Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Thursday 25 June 2015 07:01:38 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150506 04:45]: On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: It needs to be done in this code, so system_rev variable is set properly... What I mean is which code accesses this

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about Documentation/devicetree/bindings/revision.txt? For the ATAGs, Documentation/devicetree/bindings/arm/atag.txt?

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about Documentation/devicetree/bindings/revision.txt? For the

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [150706 06:14]: On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 18:20:35 Pali Rohár wrote: /chosen/linux,atags This one. ATAGs are a Linux data struct. Rob Ok, and how read that property /chosen/linux,atags in function setup_machine_fdt() from file arch/arm/kernel/devtree.c ? of_get_flat_dt_prop() cannot be used

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Pali Rohár
On Monday 06 July 2015 17:22:58 Rob Herring wrote: On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár pali.ro...@gmail.com wrote: On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 11:20 AM, Pali Rohár pali.ro...@gmail.com wrote: On Monday 06 July 2015 17:22:58 Rob Herring wrote: On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár pali.ro...@gmail.com wrote: On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150706

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren t...@atomide.com wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then how about Just revision at the top level please. I'd

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Tony Lindgren
* Rob Herring robherri...@gmail.com [150706 08:23]: On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren t...@atomide.com wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár pali.ro...@gmail.com wrote: On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150706 05:25]: into which file should I put documentation about new DT properties? If it's Linux generic like linux,revision, then

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [150625 00:29]: On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150625 00:21]: Ok, but what do you mean to forget any string conversion? No need for tohexstr() in the uncommpress code if the system_rev

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Pali Rohár
On Thursday 25 June 2015 00:22:05 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150625 00:21]: Ok, but what do you mean to forget any string conversion? No need for tohexstr() in the uncommpress code if the system_rev value is a number coming from the dts. Regards, Tony

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Russell King - ARM Linux
On Wed, May 06, 2015 at 01:44:17PM +0200, Pali Rohár wrote: On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: What I mean is which code accesses this variable that early? ATAG code is doing it at same early stage, so I added it to same early stage... ATAG code does it early because

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Pali Rohár
On Wednesday 24 June 2015 22:01:38 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150506 04:45]: On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: It needs to be done in this code, so system_rev variable is set properly... What I mean is which code accesses

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-25 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [150625 00:21]: Ok, but what do you mean to forget any string conversion? No need for tohexstr() in the uncommpress code if the system_rev value is a number coming from the dts. Regards, Tony -- To unsubscribe from this list: send the line unsubscribe

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-06-24 Thread Tony Lindgren
* Pali Rohár pali.ro...@gmail.com [150506 04:45]: On Wednesday 06 May 2015 13:04:01 Arnd Bergmann wrote: It needs to be done in this code, so system_rev variable is set properly... What I mean is which code accesses this variable that early? ATAG code is doing it at same