Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430

2008-10-06 Thread David Brownell
On Monday 06 October 2008, Tony Lindgren wrote: --- linux-omap-2.6_27_08_2008.orig/include/linux/mtd/nand.h +++ linux-omap-2.6_27_08_2008/include/linux/mtd/nand.h @@ -45,7 +45,7 @@   */  #define NAND_MAX_OOBSIZE 64  #define NAND_MAX_PAGESIZE2048 - +#define NAND_BLOCK_SIZE   

RE: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430

2008-10-06 Thread Singh, Vimal
On Modday 06 October 2008, Devid Brownell wrote: On Monday 06 October 2008, Tony Lindgren wrote: --- linux-omap-2.6_27_08_2008.orig/include/linux/mtd/nand.h +++ linux-omap-2.6_27_08_2008/include/linux/mtd/nand.h @@ -45,7 +45,7 @@ */ #define NAND_MAX_OOBSIZE 64 #define

Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430

2008-09-11 Thread David Brownell
On Thursday 11 September 2008, Singh, Vimal wrote: I will define NAND_BLOCK_SIZE as: #define NAND_BLOCK_SIZE                64 * NAND_MAX_PAGESIZE Never define such things without parentheses ... Also, that looks wrong as well as sub-optimal. Current NAND chips can have page sizes up to 4 KB

[RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430

2008-09-11 Thread vimal singh
From: Teerth Reddy [EMAIL PROTECTED] This patch adds NAND support on 3430sdp board [VS: updated for NAND_BLOCK_SIZE macros] Signed-off-by: Teerth Reddy [EMAIL PROTECTED] Signed-off-by: Vimal Singh [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-3430sdp-flash.c | 87

Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430

2008-09-10 Thread Tony Lindgren
* vimal singh [EMAIL PROTECTED] [080826 03:42]: From: Teerth Reddy [EMAIL PROTECTED] This patch adds NAND support on 3430sdp board Signed-off-by: Teerth Reddy [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-3430sdp-flash.c | 88 --