Hi All,
please comment on following patch.
Kind regards,
Wim.
commit 88d0b1a9c071d26e7b4831320067c84b04ea04a8
Author: Wim Van Sebroeck w...@iguana.be
Date: Sat Dec 26 18:55:22 2009 +
[WATCHDOG] watchdog_info separation and constify
make sure that the watchdog_info struct is
On Tue, 19 Jan 2010 22:17:59 +0100
Wim Van Sebroeck w...@iguana.be wrote:
Hi All,
please comment on following patch.
Why move them out - why not just make them const ?
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
-static struct watchdog_info at32_wdt_info = {
+static const struct watchdog_info at32_wdt_info = {
It'd be good to use a consistent structure name:
static const struct watchdog_info ident = {
etc...
}
$ grep -Poh
On Tue, Jan 19, 2010 at 16:42, Joe Perches wrote:
On Tue, 2010-01-19 at 22:17 +0100, Wim Van Sebroeck wrote:
-static struct watchdog_info at32_wdt_info = {
+static const struct watchdog_info at32_wdt_info = {
It'd be good to use a consistent structure name:
static const struct watchdog_info
On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
Maybe a standard #define WATCHDOG_NAME foo
.identity = WATCHGOD_NAME
I don't really see that the indrection via the #define would buy us
anything?
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of
On Tue, 2010-01-19 at 22:16 +, Mark Brown wrote:
On Tue, Jan 19, 2010 at 01:42:31PM -0800, Joe Perches wrote:
Maybe a standard #define WATCHDOG_NAME foo
.identity = WATCHGOD_NAME
I don't really see that the indrection via the #define would buy us
anything?
Maybe not, just a
