-in...@vger.kernel.org; linux-omap@vger.kernel.org
Subject: RE: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
Dmitry,
2 comments + one question before sending next version...
[...]
+static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
+{
Why is iti
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Wednesday, May 12, 2010 11:33 AM
To: Shilimkar, Santosh
Cc: Arce, Abraham; linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
Sorry for jumping into the comments late. Thought this was sorted out. Key
scanning
and debounce timeouts etc still there. Having all these things in ISR itself
isn't good
idea.
Dmitry,
Don't you think its optimal to push the key-scanning and debounce timeout
code
part of bottom
Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
On Wed, May 12, 2010 at 11:15:11AM +0530, Shilimkar, Santosh wrote:
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of
Arce,
Abraham
-Original Message-
From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com]
Sent: Wednesday, May 12, 2010 12:05 PM
To: Shilimkar, Santosh
Cc: Arce, Abraham; linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
Subject: Re: [RFC] [PATCH 1/3] OMAP4: Keyboard Controller Support
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
Hi again Dmitry,
No worries, although at first I was surprised that Trilok spoke exactly
the same words I did ;)
:)
+
+/* Interrupt thread handler thread */
On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
Hi again Dmitry,
No worries, although at first I was surprised that Trilok spoke exactly
the same words I
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
Hi again Dmitry,
No worries, although at first I was
] [PATCH 1/3] OMAP4: Keyboard Controller Support
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 07:53:23AM -0700, Kevin Hilman wrote:
Dmitry Torokhov dmitry.torok...@gmail.com writes:
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
Hi again
Dmitry,
2 comments + one question before sending next version...
[...]
+static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
+{
Why is iti threaded? I fo not see anything that will sleep.
It was implemented based on previous comments...
Would you point me
-Original Message-
From: linux-omap-ow...@vger.kernel.org
[mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Arce,
Abraham
Sent: Wednesday, May 12, 2010 11:10 AM
To: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org; linux-omap@vger.kernel.org
Subject: RE: [RFC] [PATCH 1/3
Hi Trilok,
Thanks for your comments...
[snip]
+
+/* Interrupt thread handler thread */
+
+static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
+{
Why is iti threaded? I fo not see anything that will sleep.
It was implemented based on previous comments...
+ struct
Sorry for the confusion in your name Dmitry...
Thanks for your comments...
[snip]
+
+/* Interrupt thread handler thread */
+
+static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
+{
Why is iti threaded? I fo not see anything that will sleep.
It was implemented
On Mon, May 10, 2010 at 11:17:50PM -0500, Arce, Abraham wrote:
Sorry for the confusion in your name Dmitry...
No worries, although at first I was surprised that Trilok spoke exactly
the same words I did ;)
Thanks for your comments...
[snip]
+
+/* Interrupt thread handler thread
Hi again Dmitry,
No worries, although at first I was surprised that Trilok spoke exactly
the same words I did ;)
:)
+
+/* Interrupt thread handler thread */
+
+static irqreturn_t omap_keypad_threaded(int irq, void *dev_id)
+{
Why is iti threaded? I fo not
On Tue, May 11, 2010 at 12:03:44AM -0500, Arce, Abraham wrote:
Hi again Dmitry,
No worries, although at first I was surprised that Trilok spoke exactly
the same words I did ;)
:)
+
+/* Interrupt thread handler thread */
+
+static irqreturn_t
Felipe,
Thanks for your comments...
[..]
+#include plat/omap_hwmod.h
+#include plat/omap_device.h
should the platform_driver know about hwmod and omap_device ? Paul ?
Kevin ?
Working on these changes...
+struct omap_keypad {
+
unnecessary blank line.
Removed
+ struct
Thanks Kevin,
Keyboard controller for OMAP4 with built-in scanning algorithm.
The following implementations are used:
- matrix_keypac.c logic
- hwmod framework
- threaded irq
Signed-off-by: Syed Rafiuddin rafiuddin.s...@ti.com
Signed-off-by: Abraham Arce x0066...@ti.com
Hi Abraham,
On Tue, Apr 13, 2010 at 08:10:48PM -0500, Arce, Abraham wrote:
Keyboard controller for OMAP4 with built-in scanning algorithm.
The following implementations are used:
- matrix_keypac.c logic
- hwmod framework
- threaded irq
Signed-off-by: Syed Rafiuddin
Arce, Abraham x0066...@ti.com writes:
Keyboard controller for OMAP4 with built-in scanning algorithm.
The following implementations are used:
- matrix_keypac.c logic
- hwmod framework
- threaded irq
Signed-off-by: Syed Rafiuddin rafiuddin.s...@ti.com
Signed-off-by: Abraham Arce
Hi Trilok!
- matrix_keypac.c logic
- hwmod framework
Do we have hwmod framework mainlined in the kernel?
Not yet but wanted to gather initial comments to be ready once framework is
pushed
+config KEYBOARD_OMAP4
+ tristate TI OMAP4 keypad support
+ depends on
Hi,
On Wed, Apr 14, 2010 at 03:10:48AM +0200, ext Arce, Abraham wrote:
+#include linux/module.h
+#include linux/init.h
+#include linux/interrupt.h
+#include linux/platform_device.h
+#include linux/errno.h
+#include linux/io.h
+#include linux/input.h
+#include linux/input/matrix_keypad.h
Hi Abraham,
On Wed, Apr 14, 2010 at 6:40 AM, Arce, Abraham x0066...@ti.com wrote:
Keyboard controller for OMAP4 with built-in scanning algorithm.
The following implementations are used:
- matrix_keypac.c logic
- hwmod framework
Do we have hwmod framework mainlined in the kernel?
23 matches
Mail list logo
