Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-22 Thread Linus Walleij
=137094012703340w=2 Can I have your ACK on this patch? I've verified combination of [PATCH] drivers: pinctrl: add active state to core [RFC] ARM: OMAP2+: omap_device: add pinctrl handling on OMAP4 SDP board+UARTs and going to send patches on Monday. So, Acked/Tested-by: Grygorii Strashko grygorii.stras

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-12 Thread Grygorii Strashko
as the first patch, i.e. this: http://marc.info/?l=linux-kernelm=137094012703340w=2 Can I have your ACK on this patch? I've verified combination of [PATCH] drivers: pinctrl: add active state to core [RFC] ARM: OMAP2+: omap_device: add pinctrl handling on OMAP4 SDP board+UARTs and going to send

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-11 Thread Tony Lindgren
* Linus Walleij linus.wall...@linaro.org [130710 13:42]: On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: I think, In the future the OMAP pinctrl configurations would be manged in more flexible way then now (thanks to pinctrl PM helpers and you;)) - Idle

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-10 Thread Linus Walleij
On Thu, Jun 27, 2013 at 4:01 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: I think, In the future the OMAP pinctrl configurations would be manged in more flexible way then now (thanks to pinctrl PM helpers and you;)) - Idle state will be splitted to Idle/sleep - default state will be

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-07-10 Thread Linus Walleij
On Thu, Jun 27, 2013 at 4:45 PM, Tony Lindgren t...@atomide.com wrote: The off mode bits can be enabled continuously, the mux hardware automatically sets them. So sounds like you don't need any separate idle sleep and off states, the following should do: default (or static) static pins that

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Tony Lindgren
* Linus Walleij linus.wall...@linaro.org [130626 12:37]: On Wed, Jun 26, 2013 at 3:20 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: The Sleep pinctrl state is optional - if sleep state isn't defined then Idle pinctrl state will be used during suspend. Why? If we have a clear cut

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Grygorii Strashko
Hi Linus, On 06/26/2013 10:31 PM, Linus Walleij wrote: On Wed, Jun 26, 2013 at 3:20 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: The Sleep pinctrl state is optional - if sleep state isn't defined then Idle pinctrl state will be used during suspend. Why? If we have a clear cut

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Tony Lindgren
* Grygorii Strashko grygorii.stras...@ti.com [130627 07:12]: As you can see, from 12 pins only 3 pins need to be reconfigured while switching from active-idle states and back (and as I mentioned above for OMAP idle == sleep now). Regarding OFF state: OMAP mux HW defines special state for

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-27 Thread Grygorii Strashko
On 06/27/2013 05:45 PM, Tony Lindgren wrote: * Grygorii Strashko grygorii.stras...@ti.com [130627 07:12]: As you can see, from 12 pins only 3 pins need to be reconfigured while switching from active-idle states and back (and as I mentioned above for OMAP idle == sleep now). Regarding OFF

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-26 Thread Grygorii Strashko
Hi All, On 06/25/2013 09:58 AM, Tony Lindgren wrote: * Linus Walleij linus.wall...@linaro.org [130624 05:13]: On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add pinctrl handling in omap_device core: 1) on PM runtime resume - switch pinctrl state to

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-26 Thread Grygorii Strashko
Picture format fixed. Sorry for that. On 06/26/2013 04:20 PM, Grygorii Strashko wrote: Hi All, On 06/25/2013 09:58 AM, Tony Lindgren wrote: * Linus Walleij linus.wall...@linaro.org [130624 05:13]: On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-26 Thread Linus Walleij
On Wed, Jun 26, 2013 at 3:20 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: The Sleep pinctrl state is optional - if sleep state isn't defined then Idle pinctrl state will be used during suspend. Why? If we have a clear cut semantic that idle is for runtime suspend, why should it be a

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-25 Thread Tony Lindgren
* Linus Walleij linus.wall...@linaro.org [130624 05:13]: On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add pinctrl handling in omap_device core: 1) on PM runtime resume - switch pinctrl state to default (todo: active) 2) on PM runtime suspend

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-24 Thread Linus Walleij
On Fri, Jun 21, 2013 at 5:03 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Hence, add pinctrl handling in omap_device core: 1) on PM runtime resume - switch pinctrl state to default (todo: active) 2) on PM runtime suspend - switch pinctrl state to idle 3) during system wide suspend

Re: [RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-24 Thread Kevin Hilman
Hi Grygorii, Grygorii Strashko grygorii.stras...@ti.com writes: Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod framework. After switching to DT-boot the pinctrl handling was dropped from hwmod framework and, as it was recommended, OMAP IP's drivers have to be

[RFC] ARM: OMAP2+: omap_device: add pinctrl handling

2013-06-21 Thread Grygorii Strashko
Before switching to DT pinctrl states of OMAP IPs have been handled by hwmod framework. After switching to DT-boot the pinctrl handling was dropped from hwmod framework and, as it was recommended, OMAP IP's drivers have to be updated to handle pinctrl states by itself using pinctrl_pm_select_xx()