[RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-02-02 Thread Peter Ujfalusi
twl6040 is a separate chip, it is not part of the twl6030 PMIC. Complete the separation of the twl6040 from the twl core. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c| 12 ++-- arch/arm/mach-omap2/board-generic.c|2 +-

Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-02-02 Thread Mark Brown
On Thu, Feb 02, 2012 at 02:16:54PM +0200, Peter Ujfalusi wrote: +static int twl6040_i2c_read(struct i2c_client *i2c, u8 *value, u8 reg) +{ + struct i2c_msg msg[2]; + int ret; May as well convert to regmap while you're at it, saves some code and will get you access to the regmap

Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-02-02 Thread Mark Brown
On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote: On 02/02/2012 02:48 PM, Mark Brown wrote: The calling convention here seems a bit weird too, you've got value then register but normally we have register then value for I2C/SPI devices. I have based these part on the