RE: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-28 Thread Hiremath, Vaibhav
PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support On Wed, 7 Jan 2009 15:51:53 +0530 Hiremath, Vaibhav hvaib...@ti.com wrote: [Hiremath, Vaibhav] Mauro, the Daughter card not only supports TVP1546/sensor but also supports USB EHCI. So this driver may not be fit into V4L driver

RE: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-28 Thread Hiremath, Vaibhav
; Hadli, Manjunath; R, Sivaraj Subject: Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support On Tuesday 06 January 2009, hvaib...@ti.com wrote: +config MACH_OMAP3EVM_DC +   bool OMAP 3530 EVM daughter card board +   depends on ARCH_OMAP3 ARCH_OMAP34XX MACH_OMAP3EVM

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-28 Thread David Brownell
+config MACH_OMAP3EVM_DC +   bool OMAP 3530 EVM daughter card board +   depends on ARCH_OMAP3 ARCH_OMAP34XX MACH_OMAP3EVM There can be other daughtercards, so the Kconfig text should say which specific card is being configured. And it should probably use the zero or

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-11 Thread Mauro Carvalho Chehab
On Sat, 10 Jan 2009 04:41:21 +0300 Alexey Klimov klimov.li...@gmail.com wrote: On Wed, 2009-01-07 at 11:37 +0530, hvaib...@ti.com wrote: [...] You have a lot of dprintk messages. May be it's better to move \n to dprintk definition? And use dprintk without \n. Probably, makes your life

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-11 Thread David Brownell
On Tuesday 06 January 2009, hvaib...@ti.com wrote: +config MACH_OMAP3EVM_DC +   bool OMAP 3530 EVM daughter card board +   depends on ARCH_OMAP3 ARCH_OMAP34XX MACH_OMAP3EVM There can be other daughtercards, so the Kconfig text should say which specific card is being configured. And

RE: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-08 Thread Hiremath, Vaibhav
, Manjunath; R, Sivaraj Subject: Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support Hi, Few comments below. * hvaib...@ti.com hvaib...@ti.com [090107 08:09]: From: Vaibhav Hiremath hvaib...@ti.com This is first version of OMAP3EVM Mulit-Media Daughter Card

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-07 Thread Mauro Carvalho Chehab
On Wed, 7 Jan 2009 11:37:50 +0530 hvaib...@ti.com wrote: arch/arm/mach-omap2/Kconfig |4 + arch/arm/mach-omap2/Makefile|1 + arch/arm/mach-omap2/. | 417 +++ arch/arm/mach-omap2/board-omap3evm-dc.h | 43