Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-28 Thread Laurent Pinchart
Hi, On Tuesday 27 July 2010 21:05:11 Sin, David wrote: On Tuesday 27 July 2010 13:38:00 Hiremath, Vaibhav wrote: On Saturday 24 July 2010 04:52:00 Sin, David wrote: This patch adds support for DMM-PAT initialization and programming. [snip] diff --git

Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-28 Thread Laurent Pinchart
On Tuesday 27 July 2010 21:53:28 Hiremath, Vaibhav wrote: On Wednesday 28 July 2010 00:35:00 Sin, David wrote: On Tuesday 27 July 2010 01:38:00 Hiremath, Vaibhav wrote: On Saturday 24 July 2010 04:52:00 Sin, David wrote: [snip] [Hiremath, Vaibhav] If I understand correctly, DMM stands

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-28 Thread Sin, David
; Kanigeri, Hari; Shilimkar, Santosh; Molnar, Lajos Subject: Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER On Tuesday 27 July 2010 21:53:28 Hiremath, Vaibhav wrote: On Wednesday 28 July 2010 00:35:00 Sin, David wrote: On Tuesday 27 July 2010 01:38:00 Hiremath, Vaibhav wrote: On Saturday

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-28 Thread Hiremath, Vaibhav
Subject: RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Wednesday, July 28, 2010 5:00 AM To: linux-arm-ker...@lists.infradead.org Cc: Hiremath, Vaibhav; Sin, David; linux-omap

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-27 Thread Hiremath, Vaibhav
-Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Sin, David; Molnar, Lajos

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-27 Thread Hiremath, Vaibhav
; Shilimkar, Santosh; Molnar, Lajos Subject: RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER -Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-26 Thread Sin, David
@vger.kernel.org; Tony Lindgren; Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav; Shilimkar, Santosh; Molnar, Lajos Subject: Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER On Fri, Jul 23, 2010 at 06:22:21PM -0500, David Sin wrote: +static struct platform_driver dmm_driver_ldm = { + .driver

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-26 Thread Sin, David
To: linux-arm-ker...@lists.infradead.org Cc: Sin, David; Molnar, Lajos Subject: Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER Hi David, On Saturday 24 July 2010 01:28:07 David Sin wrote: This patch adds support for DMM-PAT initialization and programming. Signed-off-by: David Sin david

RE: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Shilimkar, Santosh
Good to see this driver on list. Few comments. -Original Message- From: Sin, David Sent: Saturday, July 24, 2010 4:52 AM To: linux-arm-ker...@lists.arm.linux.org.uk; linux-omap@vger.kernel.org; Tony Lindgren; Russell King Cc: Kanigeri, Hari; Ohad Ben-Cohen; Hiremath, Vaibhav;

Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Russell King - ARM Linux
On Fri, Jul 23, 2010 at 06:22:21PM -0500, David Sin wrote: +static struct platform_driver dmm_driver_ldm = { + .driver = { + .owner = THIS_MODULE, + .name = dmm, + }, + .probe = NULL, + .shutdown = NULL, + .remove = NULL, +}; What's the point

Re: [RFC 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-07-24 Thread Russell King - ARM Linux
This is what I'd expect to see. This uses a hardware-upwards registration scheme, so by registering a 'dmm' device, when the driver for 'dmm' gets registered, it automatically registers with the next level up. However, you should think carefully about this kind of layered approach. Would it be