Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Russell King - ARM Linux
On Mon, Sep 28, 2015 at 11:01:34AM +0200, Arnaud Pouliquen wrote: > few questions/remarks > BR, > Arnaud > > >+static void hdmi_codec_abort(struct device *dev) > >+{ > >+struct hdmi_codec_priv *hcp = dev_get_drvdata(dev); > >+ > >+dev_dbg(dev, "%s()\n", __func__); > >+ > >+

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Jyri Sarha
On 09/28/15 12:01, Arnaud Pouliquen wrote: few questions/remarks BR, Arnaud +static void hdmi_codec_abort(struct device *dev) +{ +struct hdmi_codec_priv *hcp = dev_get_drvdata(dev); + +dev_dbg(dev, "%s()\n", __func__); + +mutex_lock(>current_stream_lock); +if

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2015 at 12:26:28PM +0100, Russell King - ARM Linux wrote: > On Mon, Sep 28, 2015 at 11:01:34AM +0200, Arnaud Pouliquen wrote: > > few questions/remarks > > BR, > > Arnaud > > > > >+static void hdmi_codec_abort(struct device *dev) > > >+{ > > >+struct hdmi_codec_priv *hcp =

Re:[PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-28 Thread Arnaud Pouliquen
few questions/remarks BR, Arnaud +static void hdmi_codec_abort(struct device *dev) +{ +struct hdmi_codec_priv *hcp = dev_get_drvdata(dev); + +dev_dbg(dev, "%s()\n", __func__); + +mutex_lock(>current_stream_lock); +if (hcp->current_stream && hcp->current_stream->runtime && +

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-21 Thread Jyri Sarha
On 09/21/15 12:31, Russell King - ARM Linux wrote: On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote: On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote: +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE |\ +

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-21 Thread Russell King - ARM Linux
On Sat, Sep 19, 2015 at 10:54:51AM -0700, Mark Brown wrote: > On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote: > > +#define SPDIF_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | > > SNDRV_PCM_FMTBIT_S16_BE |\ > > +SNDRV_PCM_FMTBIT_S20_3LE | SNDRV_PCM_FMTBIT_S20_3BE |\ > > +

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-21 Thread Mark Brown
On Mon, Sep 21, 2015 at 04:41:20PM +0300, Jyri Sarha wrote: > On 09/21/15 12:31, Russell King - ARM Linux wrote: > >The device may accept 32 bit I2S, but it would have to be truncated to > >24 bit before transmitting it to the sink. This should be mentioned > >somewhere. > There is ".sig_bits =

Re: [PATCH RFC v4 3/8] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-09-19 Thread Mark Brown
On Fri, Sep 18, 2015 at 02:06:40PM +0300, Jyri Sarha wrote: > +#define SPDIF_FORMATS(SNDRV_PCM_FMTBIT_S16_LE | > SNDRV_PCM_FMTBIT_S16_BE |\ > + SNDRV_PCM_FMTBIT_S20_3LE | SNDRV_PCM_FMTBIT_S20_3BE |\ > + SNDRV_PCM_FMTBIT_S24_3LE |