Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Eduardo Valentin
Hello Dan, On 15-03-2013 17:09, Dan Carpenter wrote: On Fri, Mar 15, 2013 at 08:59:55AM -0400, Eduardo Valentin wrote: This patch introduce a macro to read, update, write bitfields. It will be specific to bandgap data structures. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com ---

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-16 Thread Dan Carpenter
On Sat, Mar 16, 2013 at 08:36:51AM -0400, Eduardo Valentin wrote: But that said, I don't care for the RMW_BITS() very much as a long term thing. If we just used pointers instead of passing the offset into the bg_ptr-conf-sensors[] array then everything would be a lot cleaner. In other

Re: [PATCH 07/50] staging: omap-thermal: introduce RMW_BITS macro

2013-03-15 Thread Dan Carpenter
On Fri, Mar 15, 2013 at 08:59:55AM -0400, Eduardo Valentin wrote: This patch introduce a macro to read, update, write bitfields. It will be specific to bandgap data structures. Signed-off-by: Eduardo Valentin eduardo.valen...@ti.com --- drivers/staging/omap-thermal/omap-bandgap.c | 178